linux-kernel - Re: [PATCH v2 7/8] dt-bindings: ufs: mediatek,ufs: Document additional clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7fcbae7-fd54-4ad5-8dc6-4deb80088b79@collabora.com>
Date: Thu, 11 Apr 2024 17:14:34 +0200
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Conor Dooley <conor@...nel.org>
Cc: linux-scsi@...r.kernel.org, alim.akhtar@...sung.com, avri.altman@....com,
 bvanassche@....org, robh@...nel.org, krzysztof.kozlowski+dt@...aro.org,
 conor+dt@...nel.org, peter.wang@...iatek.com, chu.stanley@...il.com,
 jejb@...ux.ibm.com, martin.petersen@...cle.com, lgirdwood@...il.com,
 broonie@...nel.org, matthias.bgg@...il.com, stanley.chu@...iatek.com,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 7/8] dt-bindings: ufs: mediatek,ufs: Document
 additional clocks

Il 11/04/24 17:10, Conor Dooley ha scritto:
> On Thu, Apr 11, 2024 at 01:42:59PM +0200, AngeloGioacchino Del Regno wrote:
>> Add additional clocks, used on all MediaTek SoCs' UFSHCI controllers:
> 
> I appreciate being told they're on all, rather than it being unsaid and
> having to ask.
> 

You're welcome :-)

>> some of these clocks are optional and used only for scaling purposes
>> to save power, or to improve performance in the case of the crypt
>> clocks.
>>
>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>> ---
>>   .../devicetree/bindings/ufs/mediatek,ufs.yaml      | 14 +++++++++++++-
>>   1 file changed, 13 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
>> index e2c276da3f2c..21b038db100c 100644
>> --- a/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
>> +++ b/Documentation/devicetree/bindings/ufs/mediatek,ufs.yaml
>> @@ -26,11 +26,23 @@ properties:
>>             - const: mediatek,mt8183-ufshci
>>   
>>     clocks:
>> -    maxItems: 1
>> +    minItems: 1
> 
> Could you add an itemised list to the clocks property please?
> 

Not really... Honestly, I'm not confident that the description will be 100%
correct for all of them... can we do that at a later time, when I will be
really that much confident in writing down a proper description for each
of them?

The only thing that I'm really sure of is exactly what I wrote in this commit,
nothing less, nothing more... for now :')

Cheers,
Angelo

>>   
>>     clock-names:
>> +    minItems: 1
>>       items:
>>         - const: ufs
>> +      - const: ufs-aes
> 
> 
>> +      - const: ufs-tick
>> +      - const: unipro-sys
>> +      - const: unipro-tick
>> +      - const: ufs-sap
>> +      - const: ufs-tx-symbol
>> +      - const: ufs-rx-symbol
>> +      - const: ufs-mem
>> +      - const: crypt-mux
>> +      - const: crypt-lp
>> +      - const: crypt-perf
>>   
>>     phys:
>>       maxItems: 1
>> -- 
>> 2.44.0
>>