linux-kernel - Re: [PATCH v2 1/1] regulator: pca9450: make warm reset on PMIC_RST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZhgB1ifgrg0zeZtv@engicam>
Date: Thu, 11 Apr 2024 17:29:26 +0200
From: Fabio Aiuto <fabio.aiuto@...icam.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
	linux-kernel@...r.kernel.org, Matteo Lisi <matteo.lisi@...icam.com>,
	Mirko Ardinghi <mirko.ardinghi@...icam.com>
Subject: Re: [PATCH v2 1/1] regulator: pca9450: make warm reset on PMIC_RST_B
 assertion

Dear Krzysztof,

Il Thu, Apr 11, 2024 at 04:46:06PM +0200, Krzysztof Kozlowski ha scritto:
> On 11/04/2024 12:01, Fabio Aiuto wrote:
> > The default configuration of the PMIC behavior makes the PMIC
> > power cycle most regulators on PMIC_RST_B assertion. This power
> > cycling causes the memory contents of OCRAM to be lost.
> > Some systems needs some memory that survives reset and
> > reboot, therefore this patch is created.
> > 
> > This patch extends commit 2364a64d0673 ("regulator: pca9450:
> > Make warm reset on WDOG_B assertion") to the other reset
> > input source PMIC_RST_B as per pmic specs.
> > 
> > CC: Matteo Lisi <matteo.lisi@...icam.com>
> > CC: Mirko Ardinghi <mirko.ardinghi@...icam.com>
> > Signed-off-by: Fabio Aiuto <fabio.aiuto@...icam.com>
> > ---
> >  .../bindings/regulator/nxp,pca9450-regulator.yaml     |  6 ++++++
> 
> Please run scripts/checkpatch.pl and fix reported warnings. Then please
> run `scripts/checkpatch.pl --strict` and (probably) fix more warnings.
> Some warnings can be ignored, especially from --strict run, but the code
> here looks like it needs a fix. Feel free to get in touch if the warning
> is not clear.
> 
> >  drivers/regulator/pca9450-regulator.c                 | 11 ++++++++---
> >  include/linux/regulator/pca9450.h                     |  6 ++++++
> >  3 files changed, 20 insertions(+), 3 deletions(-)
> > 
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
> 
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on some
> ancient tree (don't, instead use mainline), work on fork of kernel
> (don't, instead use mainline) or you ignore some maintainers (really
> don't). Just use b4 and everything should be fine, although remember
> about `b4 prep --auto-to-cc` if you added new patches to the patchset.
> 
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time, thus I will skip this patch entirely till you follow
> the process allowing the patch to be tested.
> 
> Please kindly resend and include all necessary To/Cc entries.
> 
> 
> 
> Also: underscores are not allowed in property names.

thanks a lot for all suggestions, will send a patchset soon.

kind regards,

fabio

> 
> Best regards,
> Krzysztof
>