| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20240411153126.16201-22-axboe@kernel.dk>
Date: Thu, 11 Apr 2024 09:12:41 -0600
From: Jens Axboe <axboe@...nel.dk>
To: linux-kernel@...r.kernel.org
Cc: Jens Axboe <axboe@...nel.dk>
Subject: [PATCH 021/437] char/ipmi: convert to read/write iterators
Signed-off-by: Jens Axboe <axboe@...nel.dk>
---
drivers/char/ipmi/bt-bmc.c | 27 +++++++++++++--------------
drivers/char/ipmi/ipmb_dev_int.c | 19 ++++++++++---------
drivers/char/ipmi/ipmi_watchdog.c | 16 ++++++++--------
drivers/char/ipmi/kcs_bmc_cdev_ipmi.c | 23 ++++++++++++-----------
drivers/char/ipmi/ssif_bmc.c | 25 ++++++++++++++-----------
5 files changed, 57 insertions(+), 53 deletions(-)
diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
index 7450904e330a..d8b2e513ed2a 100644
--- a/drivers/char/ipmi/bt-bmc.c
+++ b/drivers/char/ipmi/bt-bmc.c
@@ -15,6 +15,7 @@
#include <linux/poll.h>
#include <linux/sched.h>
#include <linux/timer.h>
+#include <linux/uio.h>
/*
* This is a BMC device used to communicate to the host
@@ -172,17 +173,17 @@ static int bt_bmc_open(struct inode *inode, struct file *file)
* Length NetFn/LUN Seq Cmd Data
*
*/
-static ssize_t bt_bmc_read(struct file *file, char __user *buf,
- size_t count, loff_t *ppos)
+static ssize_t bt_bmc_read(struct kiocb *iocb, struct iov_iter *to)
{
- struct bt_bmc *bt_bmc = file_bt_bmc(file);
+ struct bt_bmc *bt_bmc = file_bt_bmc(iocb->ki_filp);
+ size_t count = iov_iter_count(to);
u8 len;
int len_byte = 1;
u8 kbuffer[BT_BMC_BUFFER_SIZE];
ssize_t ret = 0;
ssize_t nread;
- WARN_ON(*ppos);
+ WARN_ON(iocb->ki_pos);
if (wait_event_interruptible(bt_bmc->queue,
bt_inb(bt_bmc, BT_CTRL) & BT_CTRL_H2B_ATN))
@@ -215,12 +216,11 @@ static ssize_t bt_bmc_read(struct file *file, char __user *buf,
bt_readn(bt_bmc, kbuffer + len_byte, nread);
- if (copy_to_user(buf, kbuffer, nread + len_byte)) {
+ if (!copy_to_iter_full(kbuffer, nread + len_byte, to)) {
ret = -EFAULT;
break;
}
len -= nread;
- buf += nread + len_byte;
ret += nread + len_byte;
len_byte = 0;
}
@@ -238,10 +238,10 @@ static ssize_t bt_bmc_read(struct file *file, char __user *buf,
* Byte 1 Byte 2 Byte 3 Byte 4 Byte 5 Byte 6:N
* Length NetFn/LUN Seq Cmd Code Data
*/
-static ssize_t bt_bmc_write(struct file *file, const char __user *buf,
- size_t count, loff_t *ppos)
+static ssize_t bt_bmc_write(struct kiocb *iocb, struct iov_iter *from)
{
- struct bt_bmc *bt_bmc = file_bt_bmc(file);
+ struct bt_bmc *bt_bmc = file_bt_bmc(iocb->ki_filp);
+ size_t count = iov_iter_count(from);
u8 kbuffer[BT_BMC_BUFFER_SIZE];
ssize_t ret = 0;
ssize_t nwritten;
@@ -252,7 +252,7 @@ static ssize_t bt_bmc_write(struct file *file, const char __user *buf,
if (count < 5)
return -EINVAL;
- WARN_ON(*ppos);
+ WARN_ON(iocb->ki_pos);
/*
* There's no interrupt for clearing bmc busy so we have to
@@ -275,7 +275,7 @@ static ssize_t bt_bmc_write(struct file *file, const char __user *buf,
while (count) {
nwritten = min_t(ssize_t, count, sizeof(kbuffer));
- if (copy_from_user(&kbuffer, buf, nwritten)) {
+ if (!copy_from_iter_full(&kbuffer, nwritten, from)) {
ret = -EFAULT;
break;
}
@@ -283,7 +283,6 @@ static ssize_t bt_bmc_write(struct file *file, const char __user *buf,
bt_writen(bt_bmc, kbuffer, nwritten);
count -= nwritten;
- buf += nwritten;
ret += nwritten;
}
@@ -338,8 +337,8 @@ static __poll_t bt_bmc_poll(struct file *file, poll_table *wait)
static const struct file_operations bt_bmc_fops = {
.owner = THIS_MODULE,
.open = bt_bmc_open,
- .read = bt_bmc_read,
- .write = bt_bmc_write,
+ .read_iter = bt_bmc_read,
+ .write_iter = bt_bmc_write,
.release = bt_bmc_release,
.poll = bt_bmc_poll,
.unlocked_ioctl = bt_bmc_ioctl,
diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c
index 49100845fcb7..5344095e32a0 100644
--- a/drivers/char/ipmi/ipmb_dev_int.c
+++ b/drivers/char/ipmi/ipmb_dev_int.c
@@ -71,11 +71,11 @@ static inline struct ipmb_dev *to_ipmb_dev(struct file *file)
return container_of(file->private_data, struct ipmb_dev, miscdev);
}
-static ssize_t ipmb_read(struct file *file, char __user *buf, size_t count,
- loff_t *ppos)
+static ssize_t ipmb_read(struct kiocb *iocb, struct iov_iter *to)
{
- struct ipmb_dev *ipmb_dev = to_ipmb_dev(file);
+ struct ipmb_dev *ipmb_dev = to_ipmb_dev(iocb->ki_filp);
struct ipmb_request_elem *queue_elem;
+ size_t count = iov_iter_count(to);
struct ipmb_msg msg;
ssize_t ret = 0;
@@ -86,7 +86,7 @@ static ssize_t ipmb_read(struct file *file, char __user *buf, size_t count,
while (list_empty(&ipmb_dev->request_queue)) {
spin_unlock_irq(&ipmb_dev->lock);
- if (file->f_flags & O_NONBLOCK)
+ if (iocb->ki_filp->f_flags & O_NONBLOCK)
return -EAGAIN;
ret = wait_event_interruptible(ipmb_dev->wait_queue,
@@ -107,7 +107,7 @@ static ssize_t ipmb_read(struct file *file, char __user *buf, size_t count,
spin_unlock_irq(&ipmb_dev->lock);
count = min_t(size_t, count, msg.len + 1);
- if (copy_to_user(buf, &msg, count))
+ if (!copy_to_iter_full(&msg, count, to))
ret = -EFAULT;
return ret < 0 ? ret : count;
@@ -176,6 +176,7 @@ static ssize_t ipmb_write(struct file *file, const char __user *buf,
return ret < 0 ? ret : count;
}
+FOPS_WRITE_ITER_HELPER(ipmb_write);
static __poll_t ipmb_poll(struct file *file, poll_table *wait)
{
@@ -193,10 +194,10 @@ static __poll_t ipmb_poll(struct file *file, poll_table *wait)
}
static const struct file_operations ipmb_fops = {
- .owner = THIS_MODULE,
- .read = ipmb_read,
- .write = ipmb_write,
- .poll = ipmb_poll,
+ .owner = THIS_MODULE,
+ .read_iter = ipmb_read,
+ .write_iter = ipmb_write_iter,
+ .poll = ipmb_poll,
};
/* Called with ipmb_dev->lock held. */
diff --git a/drivers/char/ipmi/ipmi_watchdog.c b/drivers/char/ipmi/ipmi_watchdog.c
index 9a459257489f..001a6b522ce4 100644
--- a/drivers/char/ipmi/ipmi_watchdog.c
+++ b/drivers/char/ipmi/ipmi_watchdog.c
@@ -37,6 +37,7 @@
#include <linux/delay.h>
#include <linux/atomic.h>
#include <linux/sched/signal.h>
+#include <linux/uio.h>
#ifdef CONFIG_X86
/*
@@ -777,12 +778,11 @@ static ssize_t ipmi_write(struct file *file,
}
return len;
}
+FOPS_WRITE_ITER_HELPER(ipmi_write);
-static ssize_t ipmi_read(struct file *file,
- char __user *buf,
- size_t count,
- loff_t *ppos)
+static ssize_t ipmi_read(struct kiocb *iocb, struct iov_iter *to)
{
+ size_t count = iov_iter_count(to);
int rv = 0;
wait_queue_entry_t wait;
@@ -795,7 +795,7 @@ static ssize_t ipmi_read(struct file *file,
*/
spin_lock_irq(&ipmi_read_lock);
if (!data_to_read) {
- if (file->f_flags & O_NONBLOCK) {
+ if (iocb->ki_filp->f_flags & O_NONBLOCK) {
rv = -EAGAIN;
goto out;
}
@@ -821,7 +821,7 @@ static ssize_t ipmi_read(struct file *file,
spin_unlock_irq(&ipmi_read_lock);
if (rv == 0) {
- if (copy_to_user(buf, &data_to_read, 1))
+ if (!copy_to_iter_full(&data_to_read, 1, to))
rv = -EFAULT;
else
rv = 1;
@@ -895,9 +895,9 @@ static int ipmi_close(struct inode *ino, struct file *filep)
static const struct file_operations ipmi_wdog_fops = {
.owner = THIS_MODULE,
- .read = ipmi_read,
+ .read_iter = ipmi_read,
.poll = ipmi_poll,
- .write = ipmi_write,
+ .write_iter = ipmi_write_iter,
.unlocked_ioctl = ipmi_unlocked_ioctl,
.compat_ioctl = compat_ptr_ioctl,
.open = ipmi_open,
diff --git a/drivers/char/ipmi/kcs_bmc_cdev_ipmi.c b/drivers/char/ipmi/kcs_bmc_cdev_ipmi.c
index cf670e891966..1cd9b4c1fec9 100644
--- a/drivers/char/ipmi/kcs_bmc_cdev_ipmi.c
+++ b/drivers/char/ipmi/kcs_bmc_cdev_ipmi.c
@@ -16,6 +16,7 @@
#include <linux/poll.h>
#include <linux/sched.h>
#include <linux/slab.h>
+#include <linux/uio.h>
#include "kcs_bmc_client.h"
@@ -317,15 +318,15 @@ static __poll_t kcs_bmc_ipmi_poll(struct file *filp, poll_table *wait)
return mask;
}
-static ssize_t kcs_bmc_ipmi_read(struct file *filp, char __user *buf,
- size_t count, loff_t *ppos)
+static ssize_t kcs_bmc_ipmi_read(struct kiocb *iocb, struct iov_iter *to)
{
- struct kcs_bmc_ipmi *priv = to_kcs_bmc(filp);
+ struct kcs_bmc_ipmi *priv = to_kcs_bmc(iocb->ki_filp);
+ size_t count = iov_iter_count(to);
bool data_avail;
size_t data_len;
ssize_t ret;
- if (!(filp->f_flags & O_NONBLOCK))
+ if (!(iocb->ki_filp->f_flags & O_NONBLOCK))
wait_event_interruptible(priv->queue,
priv->data_in_avail);
@@ -356,7 +357,7 @@ static ssize_t kcs_bmc_ipmi_read(struct file *filp, char __user *buf,
goto out_unlock;
}
- if (copy_to_user(buf, priv->kbuffer, data_len)) {
+ if (!copy_to_iter_full(priv->kbuffer, data_len, to)) {
ret = -EFAULT;
goto out_unlock;
}
@@ -379,10 +380,10 @@ static ssize_t kcs_bmc_ipmi_read(struct file *filp, char __user *buf,
return ret;
}
-static ssize_t kcs_bmc_ipmi_write(struct file *filp, const char __user *buf,
- size_t count, loff_t *ppos)
+static ssize_t kcs_bmc_ipmi_write(struct kiocb *iocb, struct iov_iter *from)
{
- struct kcs_bmc_ipmi *priv = to_kcs_bmc(filp);
+ struct kcs_bmc_ipmi *priv = to_kcs_bmc(iocb->ki_filp);
+ size_t count = iov_iter_count(from);
ssize_t ret;
/* a minimum response size '3' : netfn + cmd + ccode */
@@ -391,7 +392,7 @@ static ssize_t kcs_bmc_ipmi_write(struct file *filp, const char __user *buf,
mutex_lock(&priv->mutex);
- if (copy_from_user(priv->kbuffer, buf, count)) {
+ if (!copy_from_iter_full(priv->kbuffer, count, from)) {
ret = -EFAULT;
goto out_unlock;
}
@@ -459,8 +460,8 @@ static int kcs_bmc_ipmi_release(struct inode *inode, struct file *filp)
static const struct file_operations kcs_bmc_ipmi_fops = {
.owner = THIS_MODULE,
.open = kcs_bmc_ipmi_open,
- .read = kcs_bmc_ipmi_read,
- .write = kcs_bmc_ipmi_write,
+ .read_iter = kcs_bmc_ipmi_read,
+ .write_iter = kcs_bmc_ipmi_write,
.release = kcs_bmc_ipmi_release,
.poll = kcs_bmc_ipmi_poll,
.unlocked_ioctl = kcs_bmc_ipmi_ioctl,
diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c
index 56346fb32872..9a907c84d182 100644
--- a/drivers/char/ipmi/ssif_bmc.c
+++ b/drivers/char/ipmi/ssif_bmc.c
@@ -130,9 +130,10 @@ static const char *state_to_string(enum ssif_state state)
}
/* Handle SSIF message that will be sent to user */
-static ssize_t ssif_bmc_read(struct file *file, char __user *buf, size_t count, loff_t *ppos)
+static ssize_t ssif_bmc_read(struct kiocb *iocb, struct iov_iter *to)
{
- struct ssif_bmc_ctx *ssif_bmc = to_ssif_bmc(file);
+ struct ssif_bmc_ctx *ssif_bmc = to_ssif_bmc(iocb->ki_filp);
+ size_t count = iov_iter_count(to);
struct ipmi_ssif_msg msg;
unsigned long flags;
ssize_t ret;
@@ -140,7 +141,7 @@ static ssize_t ssif_bmc_read(struct file *file, char __user *buf, size_t count,
spin_lock_irqsave(&ssif_bmc->lock, flags);
while (!ssif_bmc->request_available) {
spin_unlock_irqrestore(&ssif_bmc->lock, flags);
- if (file->f_flags & O_NONBLOCK)
+ if (iocb->ki_filp->f_flags & O_NONBLOCK)
return -EAGAIN;
ret = wait_event_interruptible(ssif_bmc->wait_queue,
ssif_bmc->request_available);
@@ -162,17 +163,19 @@ static ssize_t ssif_bmc_read(struct file *file, char __user *buf, size_t count,
ssif_bmc->request_available = false;
spin_unlock_irqrestore(&ssif_bmc->lock, flags);
- ret = copy_to_user(buf, &msg, count);
+ ret = -EFAULT;
+ if (copy_to_iter_full(&msg, count, to))
+ ret = 0;
}
return (ret < 0) ? ret : count;
}
/* Handle SSIF message that is written by user */
-static ssize_t ssif_bmc_write(struct file *file, const char __user *buf, size_t count,
- loff_t *ppos)
+static ssize_t ssif_bmc_write(struct kiocb *iocb, struct iov_iter *from)
{
- struct ssif_bmc_ctx *ssif_bmc = to_ssif_bmc(file);
+ struct ssif_bmc_ctx *ssif_bmc = to_ssif_bmc(iocb->ki_filp);
+ size_t count = iov_iter_count(from);
struct ipmi_ssif_msg msg;
unsigned long flags;
ssize_t ret;
@@ -180,7 +183,7 @@ static ssize_t ssif_bmc_write(struct file *file, const char __user *buf, size_t
if (count > sizeof(struct ipmi_ssif_msg))
return -EINVAL;
- if (copy_from_user(&msg, buf, count))
+ if (!copy_from_iter_full(&msg, count, from))
return -EFAULT;
if (!msg.len || count < sizeof_field(struct ipmi_ssif_msg, len) + msg.len)
@@ -189,7 +192,7 @@ static ssize_t ssif_bmc_write(struct file *file, const char __user *buf, size_t
spin_lock_irqsave(&ssif_bmc->lock, flags);
while (ssif_bmc->response_in_progress) {
spin_unlock_irqrestore(&ssif_bmc->lock, flags);
- if (file->f_flags & O_NONBLOCK)
+ if (iocb->ki_filp->f_flags & O_NONBLOCK)
return -EAGAIN;
ret = wait_event_interruptible(ssif_bmc->wait_queue,
!ssif_bmc->response_in_progress);
@@ -275,8 +278,8 @@ static int ssif_bmc_release(struct inode *inode, struct file *file)
static const struct file_operations ssif_bmc_fops = {
.owner = THIS_MODULE,
.open = ssif_bmc_open,
- .read = ssif_bmc_read,
- .write = ssif_bmc_write,
+ .read_iter = ssif_bmc_read,
+ .write_iter = ssif_bmc_write,
.release = ssif_bmc_release,
.poll = ssif_bmc_poll,
};
--
2.43.0
Powered by blists - more mailing lists