linux-kernel - [PATCH 181/437] drivers/ufs: convert to ->read_iter and ->write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240411153126.16201-182-axboe@kernel.dk>
Date: Thu, 11 Apr 2024 09:15:21 -0600
From: Jens Axboe <axboe@...nel.dk>
To: linux-kernel@...r.kernel.org
Cc: Jens Axboe <axboe@...nel.dk>
Subject: [PATCH 181/437] drivers/ufs: convert to ->read_iter and ->write_iter

Signed-off-by: Jens Axboe <axboe@...nel.dk>
---
 drivers/ufs/core/ufs-debugfs.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/ufs/core/ufs-debugfs.c b/drivers/ufs/core/ufs-debugfs.c
index e3baed6c70bd..6f5116d024f3 100644
--- a/drivers/ufs/core/ufs-debugfs.c
+++ b/drivers/ufs/core/ufs-debugfs.c
@@ -157,17 +157,17 @@ static int ufs_saved_err_show(struct seq_file *s, void *data)
 	return 0;
 }
 
-static ssize_t ufs_saved_err_write(struct file *file, const char __user *buf,
-				   size_t count, loff_t *ppos)
+static ssize_t ufs_saved_err_write(struct kiocb *iocb, struct iov_iter *from)
 {
-	struct ufs_debugfs_attr *attr = file->f_inode->i_private;
-	struct ufs_hba *hba = hba_from_file(file);
+	struct ufs_debugfs_attr *attr = iocb->ki_filp->f_inode->i_private;
+	struct ufs_hba *hba = hba_from_file(iocb->ki_filp);
+	size_t count = iov_iter_count(from);
 	char val_str[16] = { };
 	int val, ret;
 
 	if (count > sizeof(val_str))
 		return -EINVAL;
-	if (copy_from_user(val_str, buf, count))
+	if (!copy_from_iter_full(val_str, count, from))
 		return -EFAULT;
 	ret = kstrtoint(val_str, 0, &val);
 	if (ret < 0)
@@ -196,8 +196,8 @@ static int ufs_saved_err_open(struct inode *inode, struct file *file)
 static const struct file_operations ufs_saved_err_fops = {
 	.owner		= THIS_MODULE,
 	.open		= ufs_saved_err_open,
-	.read		= seq_read,
-	.write		= ufs_saved_err_write,
+	.read_iter	= seq_read_iter,
+	.write_iter	= ufs_saved_err_write,
 	.llseek		= seq_lseek,
 	.release	= single_release,
 };
-- 
2.43.0