lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <h23clexblxinnqkrxtb7cngtq4eimt65vtcqaeavjglskp2o3y@ibdua6bug4y2>
Date: Wed, 10 Apr 2024 22:15:53 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Amit Kucheria <amitk@...nel.org>, 
	Thara Gopinath <thara.gopinath@...il.com>, "Rafael J. Wysocki" <rafael@...nel.org>, 
	Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>, 
	Lukasz Luba <lukasz.luba@....com>, linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, 
	linux-pm@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH] thermal/drivers/qcom: Remove some unused fields in
 struct qpnp_tm_chip

On Tue, Apr 09, 2024 at 09:56:34PM +0200, Christophe JAILLET wrote:
> In "struct qpnp_tm_chip", the 'prev_stage' field is unused.
> Remove it.
> 
> Found with cppcheck, unusedStructMember.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Bjorn Andersson <andersson@...nel.org>

Regards,
Bjorn

> ---
> Compile tested only.
> 
> Apparently, it has never been used. It is not a left-over from a
> refactoring.
> ---
>  drivers/thermal/qcom/qcom-spmi-temp-alarm.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> index 78c5cfe6a0c0..3cd74f6cac8f 100644
> --- a/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> +++ b/drivers/thermal/qcom/qcom-spmi-temp-alarm.c
> @@ -74,7 +74,6 @@ struct qpnp_tm_chip {
>  	long				temp;
>  	unsigned int			thresh;
>  	unsigned int			stage;
> -	unsigned int			prev_stage;
>  	unsigned int			base;
>  	/* protects .thresh, .stage and chip registers */
>  	struct mutex			lock;
> -- 
> 2.44.0
> 
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ