linux-kernel - Re: [PATCH 2/2] serial: exar: adding CTI PCI/PCIe serial port support to 8250

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 11 Apr 2024 12:28:29 -0400
From: Parker Newman <parker@...est.io>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Jiri Slaby <jirislaby@...nel.org>, linux-kernel@...r.kernel.org,
 linux-serial@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
 linux-pci@...r.kernel.org, Parker Newman <pnewman@...necttech.com>
Subject: Re: [PATCH 2/2] serial: exar: adding CTI PCI/PCIe serial port
 support to 8250_exar

On Thu, 11 Apr 2024 17:55:54 +0200
Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:

> On Thu, Apr 11, 2024 at 11:29:27AM -0400, parker@...est.io wrote:
> > From: Parker Newman <pnewman@...necttech.com>
> >
> > This patch adds support for most of Connect Tech's (CTI) PCI/PCIe
> > serial cards to the 8250_exar driver.
> >
> > Major changes:
> >  - Added (optional) board_setup function called once during probe
> >  - Added exar_get_nr_ports function
> >  - Removed old Connect Tech setup functions
> >  - Added new UART family based CTI setup functions
> >  - Added PCI IDs entries for Exar XR17V25x and CTI FPGA based cards
> >  - Added MPIO functions for configuring/setting a single MPIO
> >  - Added support for reading from the Exar EEPROM
>
> When you need to list the different things you did in a single patch,
> that's a huge hint it needs to be broken up into smaller, easier to
> review, pieces.
>
> >
> > Signed-off-by: Parker Newman <pnewman@...necttech.com>
> > ---
> >  drivers/tty/serial/8250/8250_exar.c | 1089 +++++++++++++++++++++++++--
> >  1 file changed, 1019 insertions(+), 70 deletions(-)
>
> Reviewing 1000 lines of changes at once that does different things,
> isn't easy.  Please break this up into smaller,
> one-logical-step-at-a-time patches.
>
> thanks,
>
> greg k-h

I will try to split it up better and submit a v2.

Thank you,
- Parker