linux-kernel - Re: [PATCH 1/2] serial: exar: add missing CTI/Exar PCI IDs to include/linux/pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024041153-railing-recast-c4f2@gregkh>
Date: Thu, 11 Apr 2024 19:13:19 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Parker Newman <parker@...est.io>
Cc: Jiri Slaby <jirislaby@...nel.org>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>,
	linux-pci@...r.kernel.org, Parker Newman <pnewman@...necttech.com>
Subject: Re: [PATCH 1/2] serial: exar: add missing CTI/Exar PCI IDs to
 include/linux/pci_ids.h

On Thu, Apr 11, 2024 at 12:22:48PM -0400, Parker Newman wrote:
> On Thu, 11 Apr 2024 17:54:45 +0200
> Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> 
> > On Thu, Apr 11, 2024 at 11:29:26AM -0400, parker@...est.io wrote:
> > > From: Parker Newman <pnewman@...necttech.com>
> > >
> > > - Added missing CTI serial car PCI IDs
> > > - Added missing Exar XR17V25X PCI IDs
> > > - Moved XR17V4358 and XR17V8358 PCI ID defines to pci_ids.h
> >
> > Did you read the top of the pci_ids.h file?  Don't add new ids there
> > unless it is going to be needed in multiple files please.
> >
> > thanks,
> >
> > greg k-h
> No sorry I missed that... I was just trying to consolidate them all
> in one place.
> 
> Would it be better to move all the Connect Tech sub-IDs from
> pci_ids.h into 8250_exar.c? Or should I just add the missing ones
> to 8250_exar.c instead of pci_ids.h?

Just add the missing ones if you don't want to touch the pci_ids.h file,
that way it's a simpler change.

thanks,

greg k-h