linux-kernel - Re: [PATCH v2 05/10] arm64: dts: microchip: sparx5_pcb134: align I2C mux node name with bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bb0c1550-2276-48e9-85f0-3b65a784ac5c@kernel.org>
Date: Thu, 11 Apr 2024 21:06:09 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Rob Herring <robh@...nel.org>
Cc: Conor Dooley <conor@...nel.org>,
 Nicolas Ferre <nicolas.ferre@...rochip.com>,
 Claudiu Beznea <claudiu.beznea@...on.dev>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Lars Povlsen <lars.povlsen@...rochip.com>,
 Steen Hegelund <Steen.Hegelund@...rochip.com>,
 Daniel Machon <daniel.machon@...rochip.com>, UNGLinuxDriver@...rochip.com,
 Bjarni Jonasson <bjarni.jonasson@...rochip.com>,
 "David S. Miller" <davem@...emloft.net>,
 linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, horatiu.vultur@...rochip.com
Subject: Re: [PATCH v2 05/10] arm64: dts: microchip: sparx5_pcb134: align I2C
 mux node name with bindings

On 11/04/2024 20:27, Rob Herring wrote:
>>  };
>>
>>  &axi {
>> -       i2c0_imux: i2c0-imux@0 {
>> +       i2c0_imux: i2c-mux-0 {
> 
> Doesn't this introduce a new warning with simple-bus.yaml? These
> devices shouldn't be under an AXI bus which should require a
> unit-address.
> 
> All the sft-eth* nodes have the same problem:
> axi@...000000: sfp-eth63: {'compatible': ['sff,sfp'], 'i2c-bus':
> [[91]], 'tx-disable-gpios': [[87, 31, 0, 1]], 'rate-select0-gpios':
> [[87, 31, 1, 0]], 'los-gpios': [[88, 31, 0, 0]], 'mod-def0-gpios':
> [[88, 31, 1, 1]], 'tx-fault-gpios': [[88, 31, 2, 0]], 'phandle':
> [[78]]} should not be valid under {'type': 'object'}
> 

True, this replaces one dtc warning with another, so the new one is:
Warning (simple_bus_reg): /axi@...000000/i2c-mux: missing or empty
reg/ranges property

which I kind of missed, because there are several other sfp nodes
causing the warning, like you mentioned above.

The true solution is to probably bring them out of axi bus, but for that
I would need to try to understand why they were put there in the first
place...

Best regards,
Krzysztof