linux-kernel - Re: [PATCH v5 09/10] mm/ksm: rename get_ksm_page_flags() to ksm_get_folio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 11 Apr 2024 13:42:34 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: David Hildenbrand <david@...hat.com>
Cc: Alex Shi <seakeel@...il.com>, alexs@...nel.org, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org, zik.eidus@...ellosystems.com,
 willy@...radead.org, aarcange@...hat.com, hughd@...gle.com,
 chrisw@...s-sol.org
Subject: Re: [PATCH v5 09/10] mm/ksm: rename get_ksm_page_flags() to
 ksm_get_folio_flags

On Thu, 11 Apr 2024 13:46:23 +0200 David Hildenbrand <david@...hat.com> wrote:

> On 11.04.24 13:42, Alex Shi wrote:
> > 
> > 
> > On 4/11/24 3:51 PM, David Hildenbrand wrote:
> >> On 11.04.24 08:17, alexs@...nel.org wrote:
> >>> From: David Hildenbrand <david@...hat.com>
> >>>
> >>> As we are removing get_ksm_page_flags(), make the flags match the new
> >>> function name.
> >>>
> >>> Signed-off-by: David Hildenbrand <david@...hat.com>
> >>> Reviewed-by: Alex Shi <alexs@...nel.org>
> >>> ---
> >>
> >> s/get_ksm_page_flags()/get_ksm_page_flags/ in title, otherwise LGTM.
> >>
> > 
> > Uh, for this trivial issue, do I need to sent a new version? or left to maintainer for a quick fix?
> 
> I'm sure Andrew can fix that up :)

He indeed can.  Although he prefers foo() to foo.  Those two characters
have a good information-per-byte ratio.

Also I added Alex's Signed-off-by to this.

        (c) The contribution was provided directly to me by some other
            person who certified (a), (b) or (c) and I have not modified
            it.