linux-kernel - Re: [PATCH] selftests/clone3: Check that the child exited cleanly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c70a1402-4664-4200-94a5-239c7bc37392@linuxfoundation.org>
Date: Thu, 11 Apr 2024 15:03:22 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Mark Brown <broonie@...nel.org>, Christian Brauner <brauner@...nel.org>,
 Shuah Khan <shuah@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests/clone3: Check that the child exited cleanly

On 4/9/24 14:39, Mark Brown wrote:
> When the child exits during the clone3() selftest we use WEXITSTATUS() to
> get the exit status from the process without first checking WIFEXITED() to
> see if the result will be valid. This can lead to incorrect results, for
> example if the child exits due to signal. Add a WIFEXTED() check and report
> any non-standard exit as a failure, using EXIT_FAILURE as the exit status
> for call_clone3() since we otherwise report 0 or negative errnos.
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
>   tools/testing/selftests/clone3/clone3.c | 5 +++++
>   1 file changed, 5 insertions(+)

Applied to linux-kselftest next for Linux 6.10-rc1.

thanks,
-- Shuah