linux-kernel - Re: [PATCH] selftests/clone3: Correct log message for waitpid() failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c7063a50-4981-4431-af32-07b955abc776@linuxfoundation.org>
Date: Thu, 11 Apr 2024 15:03:37 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Mark Brown <broonie@...nel.org>, Christian Brauner <brauner@...nel.org>,
 Shuah Khan <shuah@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] selftests/clone3: Correct log message for waitpid()
 failures

On 4/9/24 14:40, Mark Brown wrote:
> When logging an error from calling waitpid() on the child we print a
> misleading error message saying that the error we report was returned by
> the chilld. Fix this to say the error is from waitpid().
> 
> Signed-off-by: Mark Brown <broonie@...nel.org>
> ---
>   tools/testing/selftests/clone3/clone3.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/clone3/clone3.c b/tools/testing/selftests/clone3/clone3.c
> index 3c9bf0cd82a8..eb108727c35c 100644
> --- a/tools/testing/selftests/clone3/clone3.c
> +++ b/tools/testing/selftests/clone3/clone3.c
> @@ -95,7 +95,7 @@ static int call_clone3(uint64_t flags, size_t size, enum test_mode test_mode)
>   			getpid(), pid);
>   
>   	if (waitpid(-1, &status, __WALL) < 0) {
> -		ksft_print_msg("Child returned %s\n", strerror(errno));
> +		ksft_print_msg("waitpid() returned %s\n", strerror(errno));
>   		return -errno;
>   	}
>   	if (WEXITSTATUS(status))
> 
> ---
> base-commit: 8cb4a9a82b21623dbb4b3051dd30d98356cf95bc
> change-id: 20240405-kselftest-clone3-waitpid-68c4833cf5ff
> 
> Best regards,

Applied to linux-kselftest next for Linux 6.10-rc1.

thanks,
-- Shuah