linux-kernel - Re: [PATCH V7 net-next 4/4] net: hns3: add support to query scc version by devlink info

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZheB58bjmkFzIEbG@nanopsycho>
Date: Thu, 11 Apr 2024 08:23:35 +0200
From: Jiri Pirko <jiri@...nulli.us>
To: Jijie Shao <shaojijie@...wei.com>
Cc: yisen.zhuang@...wei.com, salil.mehta@...wei.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	horms@...nel.org, rkannoth@...vell.com, shenjian15@...wei.com,
	wangjie125@...wei.com, liuyonglong@...wei.com,
	chenhao418@...wei.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V7 net-next 4/4] net: hns3: add support to query scc
 version by devlink info

Thu, Apr 11, 2024 at 03:05:53AM CEST, shaojijie@...wei.com wrote:
>
>on 2024/4/10 22:59, Jiri Pirko wrote:
>> Wed, Apr 10, 2024 at 02:53:54PM CEST, shaojijie@...wei.com wrote:
>> > From: Hao Chen <chenhao418@...wei.com>
>> > 
>> > Add support to query scc version by devlink info for device V3.
>> > 
>> > Signed-off-by: Hao Chen <chenhao418@...wei.com>
>> > Signed-off-by: Jijie Shao <shaojijie@...wei.com>
>> > ---
>> > Documentation/networking/devlink/hns3.rst     |  3 ++
>> > drivers/net/ethernet/hisilicon/hns3/hnae3.h   |  9 ++++
>> > .../hns3/hns3_common/hclge_comm_cmd.h         |  8 ++++
>> > .../hisilicon/hns3/hns3pf/hclge_devlink.c     | 44 +++++++++++++++++--
>> > .../hisilicon/hns3/hns3pf/hclge_devlink.h     |  2 +
>> > .../hisilicon/hns3/hns3pf/hclge_main.c        | 18 ++++++++
>> > .../hisilicon/hns3/hns3pf/hclge_main.h        |  1 +
>> > 7 files changed, 82 insertions(+), 3 deletions(-)
>> > 
>> > diff --git a/Documentation/networking/devlink/hns3.rst b/Documentation/networking/devlink/hns3.rst
>> > index 4562a6e4782f..e19dea8ef924 100644
>> > --- a/Documentation/networking/devlink/hns3.rst
>> > +++ b/Documentation/networking/devlink/hns3.rst
>> > @@ -23,3 +23,6 @@ The ``hns3`` driver reports the following versions
>> >     * - ``fw``
>> >       - running
>> >       - Used to represent the firmware version.
>> > +   * - ``fw.scc``
>> What's scc? I don't see it described anywhere.
>
>diff --git a/Documentation/networking/devlink/hns3.rst b/Documentation/networking/devlink/hns3.rst
>index 4562a6e4782f..e19dea8ef924 100644
>--- a/Documentation/networking/devlink/hns3.rst
>+++ b/Documentation/networking/devlink/hns3.rst
>@@ -23,3 +23,6 @@ The ``hns3`` driver reports the following versions
>    * - ``fw``
>      - running
>      - Used to represent the firmware version.
>+   * - ``fw.scc``
>+     - running
>+     - Used to represent the soft congestion control firmware version.
>
>scc means "soft congestion control"

I guess this is something specific to your device, isn't it? Can't you
please extend the description a bit more?

Thanks!

>