linux-kernel - RE: [EXT] Re: [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add rtc PCF2131 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AS4PR04MB9386603E175BED248574AE53E1052@AS4PR04MB9386.eurprd04.prod.outlook.com>
Date: Thu, 11 Apr 2024 06:37:58 +0000
From: Joy Zou <joy.zou@....com>
To: Marco Felsch <m.felsch@...gutronix.de>
CC: Jacky Bai <ping.bai@....com>, Frank Li <frank.li@....com>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "shawnguo@...nel.org"
	<shawnguo@...nel.org>, "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, dl-linux-imx <linux-imx@....com>,
	"kernel@...gutronix.de" <kernel@...gutronix.de>, "festevam@...il.com"
	<festevam@...il.com>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>
Subject: RE: [EXT] Re: [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add rtc
 PCF2131 support


> -----Original Message-----
> From: Marco Felsch <m.felsch@...gutronix.de>
> Sent: 2024年4月10日 15:40
> To: Joy Zou <joy.zou@....com>
> Cc: Jacky Bai <ping.bai@....com>; robh+dt@...nel.org;
> krzysztof.kozlowski+dt@...aro.org; conor+dt@...nel.org;
> shawnguo@...nel.org; s.hauer@...gutronix.de; devicetree@...r.kernel.org;
> imx@...ts.linux.dev; linux-kernel@...r.kernel.org; dl-linux-imx
> <linux-imx@....com>; kernel@...gutronix.de; festevam@...il.com;
> linux-arm-kernel@...ts.infradead.org
> Subject: [EXT] Re: [PATCH v3 1/1] arm64: dts: imx93-11x11-evk: add rtc
> PCF2131 support
> On 24-04-10, Joy Zou wrote:
> > Support rtc PCF2131 on imx93-11x11-evk.
> >
> > Signed-off-by: Joy Zou <joy.zou@....com>
> > ---
> > Changes in v3:
> > 1.adjust the indentation.
> >
> > Changes in v2:
> > 1. remove unnecessary status property.
> > ---
> >  .../boot/dts/freescale/imx93-11x11-evk.dts    | 24
> +++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > index 07e85a30a25f..73e0bca36b81 100644
> > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts
> > @@ -281,6 +281,23 @@ ldo5: LDO5 {
> >       };
> >  };
> >
> > +&lpi2c3 {
> > +     #address-cells = <1>;
> > +     #size-cells = <0>;
> > +     clock-frequency = <400000>;
> > +     pinctrl-names = "default", "sleep";
> > +     pinctrl-0 = <&pinctrl_lpi2c3>;
> > +     pinctrl-1 = <&pinctrl_lpi2c3>;
> 
> Are both "default" and "sleep" pinctrl's required? It doesn't make any sense
> to provde a sleep state which uses the same pinctrl state.
Thanks for your comments!
Currently, We only use default. Yeah, It's confused that a sleep state which uses the same pinctrl state.
So will remove the sleep.
BR
Joy Zou
> 
> Regards,
>   Marco
>