linux-kernel - Re: [PATCH v8 09/13] clk: hisilicon: hi3620: Convert into platform driver module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <276bd3d76b57cf2916ba968e99499096.sboyd@kernel.org>
Date: Thu, 11 Apr 2024 00:15:21 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: David Yang <mmyangfl@...il.com>, linux-clk@...r.kernel.org
Cc: Michael Turquette <mturquette@...libre.com>, linux-kernel@...r.kernel.org, David Yang <mmyangfl@...il.com>
Subject: Re: [PATCH v8 09/13] clk: hisilicon: hi3620: Convert into platform driver module

Quoting David Yang (2024-04-11 00:04:54)
> Use common helper functions and register clks with a single of_device_id
> data.
> 
> Signed-off-by: David Yang <mmyangfl@...il.com>
> ---
>  drivers/clk/hisilicon/clk-hi3620.c | 191 +++++++++++++++--------------
>  1 file changed, 96 insertions(+), 95 deletions(-)
> 
> diff --git a/drivers/clk/hisilicon/clk-hi3620.c b/drivers/clk/hisilicon/clk-hi3620.c
> index 5d0226530fdb..8832cdd6bd57 100644
> --- a/drivers/clk/hisilicon/clk-hi3620.c
> +++ b/drivers/clk/hisilicon/clk-hi3620.c
> @@ -12,6 +12,7 @@
>  #include <linux/kernel.h>
>  #include <linux/clk-provider.h>
>  #include <linux/io.h>
> +#include <linux/module.h>
>  #include <linux/of.h>
>  #include <linux/of_address.h>
>  #include <linux/slab.h>

You need to include linux/platform_device.h if you're making it into a
platform driver.