linux-kernel - Re: [PATCH net-next v2 4/5] net: stmmac: add support for RZ/N1 GMAC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMuHMdVAB8CuSkrnp+b7-+s3v0eHLr0Lvm1=MveGMVRW3T9T-A@mail.gmail.com>
Date: Thu, 11 Apr 2024 09:45:27 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Romain Gantois <romain.gantois@...tlin.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, 
	Alexandre Torgue <alexandre.torgue@...s.st.com>, Jose Abreu <joabreu@...opsys.com>, 
	Maxime Coquelin <mcoquelin.stm32@...il.com>, Russell King <linux@...linux.org.uk>, 
	Clément Léger <clement.leger@...tlin.com>, 
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>, netdev@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, 
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH net-next v2 4/5] net: stmmac: add support for RZ/N1 GMAC

Hi Romain,

On Wed, Apr 10, 2024 at 2:24 PM Romain Gantois
<romain.gantois@...tlin.com> wrote:
> On Tue, 9 Apr 2024, Geert Uytterhoeven wrote:
> > > +config DWMAC_RZN1
> > > +       tristate "Renesas RZ/N1 dwmac support"
> > > +       default ARCH_RZN1
> >
> > Why default to enabled?
> >
> > > +       depends on OF && (ARCH_RZN1 || COMPILE_TEST)
>
> The kernel doc states this as one of the possible cases where setting default
> y/m makes sense:
>
> ```
> Sub-driver behavior or similar options for a driver that is “default n”. This
> allows you to provide sane defaults.
> ```
>
> In the case of DWMAC_RZN1, it is a suboption of stmmac which is "default n", and
> I think it makes sense to enable the RZN1 ethernet controller driver if both the
> stmmac driver and the RZN1 architecture were explicitely selected.

Thanks for your answer, that makes perfect sense!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds