linux-kernel - Re: [PATCH v5 0/10] transfer page to folio in KSM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db95e01f-9334-4db8-8f8b-83f25a7dda87@redhat.com>
Date: Thu, 11 Apr 2024 09:55:28 +0200
From: David Hildenbrand <david@...hat.com>
To: alexs@...nel.org, Andrew Morton <akpm@...ux-foundation.org>,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org,
 zik.eidus@...ellosystems.com, willy@...radead.org, aarcange@...hat.com,
 hughd@...gle.com, chrisw@...s-sol.org
Subject: Re: [PATCH v5 0/10] transfer page to folio in KSM

On 11.04.24 08:17, alexs@...nel.org wrote:
> From: "Alex Shi (tencent)" <alexs@...nel.org>
> 
> This is the first part of page to folio transfer on KSM. Since only
> single page could be stored in KSM, we could safely transfer stable tree
> pages to folios.
> This patchset could reduce ksm.o 57kbytes from 2541776 bytes on latest
> akpm/mm-stable branch with CONFIG_DEBUG_VM enabled. It pass the KSM testing
> in LTP and kernel selftest.

Just a nit (no need to address for this patch set): "transfer page to 
folio" sounds very misleading to me. I'm not a native speaker, but I'd 
have called this patch set

"mm/ksm: convert some KSM code to use folios"

It's rather code conversion/transformation, not a transfer.

But again, I'm not a native speaker ...

-- 
Cheers,

David / dhildenb