linux-kernel - Re: [PATCH v9 1/9] clk: mmp: Switch to use struct u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a6e75820e5b6a96d3b1161c9dbf5a8d8.sboyd@kernel.org>
Date: Thu, 11 Apr 2024 00:56:54 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Catalin Marinas <catalin.marinas@....com>, Conor Dooley <conor+dt@...nel.org>, Duje Mihanović <duje.mihanovic@...le.hr>, Guilherme G. Piccoli <gpiccoli@...lia.com>, Haojian Zhuang <haojian.zhuang@...aro.org>, Kees Cook <keescook@...omium.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Linus Walleij <linus.walleij@...aro.org>, Lubomir Rintel <lkundrak@...sk>, Michael Turquette <mturquette@...libre.com>, Rob Herring <robh+dt@...nel.org>, Rob Herring <robh@...nel.org>, Tony Lindgren <tony@...mide.com>, Tony Luck <tony.luck@...el.com>, Will Deacon <will@...nel.org>
Cc: phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht, Karel Balej <balejk@...fyz.cz>, David Wronek <david@...nlining.org>, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Subject: Re: [PATCH v9 1/9] clk: mmp: Switch to use struct u32_fract instead of custom one

Quoting Duje Mihanović (2024-04-02 13:55:37)
> From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> 
> The struct mmp_clk_factor_tbl repeats the generic struct u32_fract.
> Kill the custom one and use the generic one instead.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Tested-by: Duje Mihanović <duje.mihanovic@...le.hr>
> Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> Signed-off-by: Duje Mihanović <duje.mihanovic@...le.hr>
> ---

Reviewed-by: Stephen Boyd <sboyd@...nel.org>

> 
> diff --git a/drivers/clk/mmp/clk.h b/drivers/clk/mmp/clk.h
> index 55ac05379781..c83cec169ddc 100644
> --- a/drivers/clk/mmp/clk.h
> +++ b/drivers/clk/mmp/clk.h
> @@ -3,6 +3,7 @@
>  #define __MACH_MMP_CLK_H
>  
>  #include <linux/clk-provider.h>
> +#include <linux/math.h>
>  #include <linux/pm_domain.h>
>  #include <linux/clkdev.h>
> 

This clkdev include should be dropped in another patch.