linux-kernel - Re: [PATCH v2 2/2] dma: dt-bindings: fsl-edma: clean up unused "fsl,imx8qm-adma" compatible string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <703311b6-ee3a-4131-ae11-57b8d765db5c@kernel.org>
Date: Thu, 11 Apr 2024 10:13:38 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Joy Zou <joy.zou@....com>, frank.li@....com, peng.fan@....com,
 vkoul@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org
Cc: imx@...ts.linux.dev, dmaengine@...r.kernel.org,
 linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 2/2] dma: dt-bindings: fsl-edma: clean up unused
 "fsl,imx8qm-adma" compatible string

On 11/04/2024 09:43, Joy Zou wrote:
> The compatible string "fsl,imx8qm-adma" is unused.

Why? Commit must stand on its own.

> 
> Signed-off-by: Joy Zou <joy.zou@....com>
> ---

Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching.

>  Documentation/devicetree/bindings/dma/fsl,edma.yaml | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> index 825f4715499e..64fa27d0cd9b 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> @@ -21,7 +21,6 @@ properties:
>        - enum:
>            - fsl,vf610-edma
>            - fsl,imx7ulp-edma
> -          - fsl,imx8qm-adma


I see more usages. One more trivial patch which is incorrect.

Did you implement the internal review?

Best regards,
Krzysztof