linux-kernel - Re: [PATCH] riscv: dts: sophgo: add initial Milk-V Duo S board device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5fdda638-21ba-4fa7-b666-33cf2fd69dda@bootlin.com>
Date: Thu, 11 Apr 2024 10:35:55 +0200
From: Michael Opdenacker <michael.opdenacker@...tlin.com>
To: Jisheng Zhang <jszhang@...nel.org>, Inochi Amaoto <inochiama@...look.com>
Cc: michael.opdenacker@...tlin.com, Conor Dooley <conor@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Chen Wang <unicorn_wang@...look.com>,
 Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] riscv: dts: sophgo: add initial Milk-V Duo S board device
 tree

Hi Jisheng,

On 4/10/24 at 12:24, Jisheng Zhang wrote:
> setting the correct bus-width is necessary for better performance
> no-1-8-v can be removed, but it doesn't harm anything because
> the board doesn't supply 1.8v
>
> no-mmc and no-sdio to make the probe a bit quicker

Many thanks for your advice!

However, whether I apply these changes or not, 
git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git is now broken 
for me:
Error: arch/riscv/boot/dts/sophgo/sg2000-milkv-duos.dts:32.1-8 Label or 
path sdhci0 not found

I was previously testing with linux-next, but it's now broken too, 
though in a different way:
[    1.306811] /dev/root: Can't open blockdev
[    1.311200] VFS: Cannot open root device "/dev/mmcblk0p2" or 
unknown-block(0,0): error -6

Shall I submit my updates anyway?
Cheers
Michael.

-- 
Michael Opdenacker, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com