linux-kernel - Re: [PATCH] bcachefs: fix typo in reference to BCACHEFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11712bdc-9119-4ad2-b4ac-f6e2d0730134@huawei.com>
Date: Thu, 11 Apr 2024 17:16:59 +0800
From: Hongbo Li <lihongbo22@...wei.com>
To: Lukas Bulwahn <lbulwahn@...hat.com>, Kent Overstreet
	<kent.overstreet@...ux.dev>, Brian Foster <bfoster@...hat.com>,
	<linux-bcachefs@...r.kernel.org>
CC: <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Lukas
 Bulwahn <lukas.bulwahn@...hat.com>
Subject: Re: [PATCH] bcachefs: fix typo in reference to BCACHEFS_DEBUG



On 2024/4/11 16:29, Lukas Bulwahn wrote:
> Commit ec9cc18fc2e6 ("bcachefs: Add checks for invalid snapshot IDs")
> intends to check the sanity of a snapshot and panic when
> BCACHEFS_DEBUG is set, but that conditional has a typo.
> 
> Fix the typo to refer to the actual existing Kconfig symbol.
> 
> This was found with ./scripts/checkkconfigsymbols.py.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...hat.com>
> ---
>   fs/bcachefs/snapshot.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/bcachefs/snapshot.h b/fs/bcachefs/snapshot.h
> index b7d2fed37c4f..3fdb41b33d2d 100644
> --- a/fs/bcachefs/snapshot.h
> +++ b/fs/bcachefs/snapshot.h
> @@ -77,7 +77,7 @@ static inline u32 __bch2_snapshot_parent(struct bch_fs *c, u32 id)
>   		return 0;
>   
>   	u32 parent = s->parent;
> -	if (IS_ENABLED(CONFIG_BCACHEFS_DEBU) &&
> +	if (IS_ENABLED(CONFIG_BCACHEFS_DEBUG) &&
>   	    parent &&
>   	    s->depth != snapshot_t(c, parent)->depth + 1)
>   		panic("id %u depth=%u parent %u depth=%u\n",

Reviewed-by: Hongbo Li <lihongbo22@...wei.com>