linux-kernel - Re: [PATCH v1 1/1] gpio: regmap: Use -ENOTSUPP consistently

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 11 Apr 2024 12:46:32 +0200
From: "Michael Walle" <mwalle@...nel.org>
To: "Andy Shevchenko" <andy.shevchenko@...il.com>,
 <linux-gpio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Cc: "Linus Walleij" <linus.walleij@...aro.org>, "Bartosz Golaszewski"
 <brgl@...ev.pl>
Subject: Re: [PATCH v1 1/1] gpio: regmap: Use -ENOTSUPP consistently

Hi Andy,

On Wed Apr 10, 2024 at 8:39 AM CEST, Andy Shevchenko wrote:
> The GPIO library expects the drivers to return -ENOTSUPP in some cases
> and not using analogue POSIX code. Make the driver to follow this.

I don't care too much, so if you like you can add

Reviewed-by: Michael Walle <mwalle@...nel.org>

But.. isn't it the wrong errno and isn't it discouraged to use it
because it's a NFS only errno? Thus, wouldn't it make more sense for
the core to accept EOPNOTSUPP and maybe convert it to ENOTSUPP if we
don't want to break userspace?

-michael

> Signed-off-by: Andy Shevchenko <andy.shevchenko@...il.com>
> ---
>  drivers/gpio/gpio-regmap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-regmap.c b/drivers/gpio/gpio-regmap.c
> index c08c8e528867e..71684dee2ca5d 100644
> --- a/drivers/gpio/gpio-regmap.c
> +++ b/drivers/gpio/gpio-regmap.c
> @@ -129,7 +129,7 @@ static int gpio_regmap_get_direction(struct gpio_chip *chip,
>  		base = gpio_regmap_addr(gpio->reg_dir_in_base);
>  		invert = 1;
>  	} else {
> -		return -EOPNOTSUPP;
> +		return -ENOTSUPP;
>  	}
>  
>  	ret = gpio->reg_mask_xlate(gpio, base, offset, &reg, &mask);
> @@ -160,7 +160,7 @@ static int gpio_regmap_set_direction(struct gpio_chip *chip,
>  		base = gpio_regmap_addr(gpio->reg_dir_in_base);
>  		invert = 1;
>  	} else {
> -		return -EOPNOTSUPP;
> +		return -ENOTSUPP;
>  	}
>  
>  	ret = gpio->reg_mask_xlate(gpio, base, offset, &reg, &mask);


Download attachment "signature.asc" of type "application/pgp-signature" (298 bytes)