linux-kernel - Re: [PATCH v7 0/8] devm_led_classdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240411110024.GF1980182@google.com>
Date: Thu, 11 Apr 2024 12:00:24 +0100
From: Lee Jones <lee@...nel.org>
To: andy.shevchenko@...il.com, pavel@....cz, vadimp@...dia.com,
	christophe.leroy@...roup.eu, hdegoede@...hat.com,
	mazziesaccount@...il.com, peterz@...radead.org, mingo@...hat.com,
	will@...nel.org, longman@...hat.com, boqun.feng@...il.com,
	nikitos.tr@...il.com, kabel@...nel.org,
	George Stark <gnstark@...utedevices.com>
Cc: linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...utedevices.com
Subject: Re: [PATCH v7 0/8] devm_led_classdev_register() usage problem

On Thu, 11 Apr 2024, Lee Jones wrote:

> On Thu, 14 Mar 2024 23:18:48 +0300, George Stark wrote:
> > This patch series fixes the problem of devm_led_classdev_register misusing.
> > 
> > The basic problem is described in [1]. Shortly when devm_led_classdev_register()
> > is used then led_classdev_unregister() called after driver's remove() callback.
> > led_classdev_unregister() calls driver's brightness_set callback and that callback
> > may use resources which were destroyed already in driver's remove().
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/8] locking/mutex: introduce devm_mutex_init()
>       commit: c1a17857f8e333aa597ce0099c8728888e0c5037
> [2/8] leds: aw2013: use devm API to cleanup module's resources
>       commit: aa2fb50d9f17185e799a5969d0d357842d07450b
> [3/8] leds: aw200xx: use devm API to cleanup module's resources
>       commit: 517d9d3c408369cfa552652ac06294410c570095
> [4/8] leds: lp3952: use devm API to cleanup module's resources
>       commit: f8cf710c971e021e5ca39832adde32dfa241e081
> [5/8] leds: lm3532: use devm API to cleanup module's resources
>       commit: d265d86a2725e38c4f13ef79fc4e685b7234e7a3
> [6/8] leds: nic78bx: use devm API to cleanup module's resources
>       commit: 917676a8961e18e4dd5b17411317e3261473762a
> [7/8] leds: mlxreg: use devm_mutex_init() for mutex initialization
>       commit: 0548081cb25fbd0eb3a605cb6647dd166368da32
> [8/8] leds: an30259a: use devm_mutex_init() for mutex initialization
>       commit: c898cf6eb464d4172c79e925ea4d8007e856e10c

Submitted for build testing.

I'll follow-up with a pull-request once everything is in order.

-- 
Lee Jones [李琼斯]