linux-kernel - Re: [PATCH] bpf: strnchr not suitable for getting NUL-terminator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 11 Apr 2024 19:05:19 +0800
From: Edward Adam Davis <eadavis@...com>
To: yonghong.song@...ux.dev
Cc: andrii@...nel.org,
	ast@...nel.org,
	bpf@...r.kernel.org,
	daniel@...earbox.net,
	eadavis@...com,
	haoluo@...gle.com,
	john.fastabend@...il.com,
	jolsa@...nel.org,
	kpsingh@...nel.org,
	linux-kernel@...r.kernel.org,
	martin.lau@...ux.dev,
	sdf@...gle.com,
	song@...nel.org,
	syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH] bpf: strnchr not suitable for getting NUL-terminator

> > The strnchr() is not suitable for obtaining the end of a string with a length
> > exceeding 1 and ending with a NUL character.
> 
> Could you give more detailed explanation with specific examples? I think
> strnchr() does the right thing here. Note that if fmt is not NULL,
> strnchrnul() never returns NULL pointer so in the change below,
> 'if (!fmt_end)' will be always false.
My mistake, strnchr() work well.
> 
> >