linux-kernel - Re: [patch 0/2] x86/cpu/amd: Fixup the topology rework fallout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6d4d3956-baf3-441c-86b6-493eb3ff72bd@leemhuis.info>
Date: Thu, 11 Apr 2024 13:37:29 +0200
From: "Linux regression tracking (Thorsten Leemhuis)"
 <regressions@...mhuis.info>
To: Laura Nao <laura.nao@...labora.com>, tglx@...utronix.de
Cc: kernel@...labora.com, linux-kernel@...r.kernel.org,
 regressions@...ts.linux.dev, x86@...nel.org,
 "kernelci.org bot" <bot@...nelci.org>
Subject: Re: [patch 0/2] x86/cpu/amd: Fixup the topology rework fallout

On 11.04.24 13:27, Laura Nao wrote:
> 
> On 4/10/24 21:45, Thomas Gleixner wrote:
>> Testing at Collabora unearthed two issues in the new AMD topology parser
>> code:
>>
>>    1) The CPUID 0x80000008 parser initializes the wrong topology domain
>>       level.
>>
>>    2) The NODEID_MSR parser uses bitfields in a union wrongly which results
>>       in reading out the wrong value and finally in a division by zero.
>>
>> Many thanks to Laura for helping to debug this issue.
>>
>>         tglx
>>
>>
> 
> Thanks a lot for investigating and solving the issue!> [...]
> 
> The regression was originally reported by KernelCI, so:
> 
> Reported-by: "kernelci.org bot" <bot@...nelci.org>
> Tested-by: Laura Nao <laura.nao@...labora.com>
> 
> I'll make sure to update the Regzbot tag when the series is merged.

No need to wait, we can do that now:

#regzbot fix: x86/cpu/amd: Make the NODEID_MSR union actually work

But ideally Thomas would add Link: or Closes: tag to the patch
description (e.g.

 Closes:
https://lore.kernel.org/all/20240322175210.124416-1-laura.nao@collabora.com/

) just like Linus asked him to do a while ago already[1], as then this
would not be necessary at all. ;) (SCNR)

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

[1]
https://lore.kernel.org/all/CAHk-=wjMmSZzMJ3Xnskdg4+GGz=5p5p+GSYyFBTh0f-DgvdBWg@mail.gmail.com/