linux-kernel - Re: [PATCH] sched/cputime: remove unused vtime_account

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b1befac0501944919cd99f20c4bcecaa@huawei.com>
Date: Thu, 11 Apr 2024 12:05:48 +0000
From: duchangbin <changbin.du@...wei.com>
To: duchangbin <changbin.du@...wei.com>
CC: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
	Juri Lelli <juri.lelli@...hat.com>, Vincent Guittot
	<vincent.guittot@...aro.org>, Dietmar Eggemann <dietmar.eggemann@....com>,
	Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>, "Mel
 Gorman" <mgorman@...e.de>, Daniel Bristot de Oliveira <bristot@...hat.com>,
	Valentin Schneider <vschneid@...hat.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sched/cputime: remove unused vtime_account_kernel

The vtime_account_idle() can also be removed. Will update this change.

On Thu, Apr 11, 2024 at 07:22:12PM +0800, Changbin Du wrote:
> This removes the vtime_account_kernel() function in generic vtime
> accounting. It's never used anymore.
> 
> Signed-off-by: Changbin Du <changbin.du@...wei.com>
> ---
>  kernel/sched/cputime.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
> index af7952f12e6c..29320e66abdc 100644
> --- a/kernel/sched/cputime.c
> +++ b/kernel/sched/cputime.c
> @@ -709,18 +709,6 @@ static void __vtime_account_kernel(struct task_struct *tsk,
>  		vtime_account_system(tsk, vtime);
>  }
>  
> -void vtime_account_kernel(struct task_struct *tsk)
> -{
> -	struct vtime *vtime = &tsk->vtime;
> -
> -	if (!vtime_delta(vtime))
> -		return;
> -
> -	write_seqcount_begin(&vtime->seqcount);
> -	__vtime_account_kernel(tsk, vtime);
> -	write_seqcount_end(&vtime->seqcount);
> -}
> -
>  void vtime_user_enter(struct task_struct *tsk)
>  {
>  	struct vtime *vtime = &tsk->vtime;
> -- 
> 2.34.1
> 

-- 
Cheers,
Changbin Du