linux-kernel - Re: [PATCH v2] serial: imx: Introduce timeout when waiting on transmitter empty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 11 Apr 2024 14:06:50 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Esben Haabendal <esben@...nix.com>
Cc: Marc Kleine-Budde <mkl@...gutronix.de>,
	Sergey Organov <sorganov@...il.com>,
	Jiri Slaby <jirislaby@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] serial: imx: Introduce timeout when waiting on
 transmitter empty

On Wed, Apr 10, 2024 at 09:18:32AM +0200, Esben Haabendal wrote:
> By waiting at most 1 second for USR2_TXDC to be set, we avoid a potential
> deadlock.
> 
> In case of the timeout, there is not much we can do, so we simply ignore
> the transmitter state and optimistically try to continue.
> 
> v2:
> - Fixed commit message typo
> - Remove reference to patch series it originated from. This is a
>   stand-alone patch

The "v2:" stuff needs to go below the --- line, so it doesn't show up in
the kernel changelog.  The kernel documentation should describe this,
right?

Please fix up and send a v3.

thanks,

greg k-h