[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zhfkinpp92Ja6Orl@gmail.com>
Date: Thu, 11 Apr 2024 15:24:26 +0200
From: Ingo Molnar <mingo@...nel.org>
To: Uros Bizjak <ubizjak@...il.com>
Cc: linux-kernel@...r.kernel.org, Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>, Will Deacon <will@...nel.org>,
Waiman Long <longman@...hat.com>, Boqun Feng <boqun.feng@...il.com>
Subject: Re: [PATCH 2/2] locking/pvqspinlock: Use try_cmpxchg() in
qspinlock_paravirt.h
* Uros Bizjak <ubizjak@...il.com> wrote:
> - locked = cmpxchg_release(&lock->locked, _Q_LOCKED_VAL, 0);
> - if (likely(locked == _Q_LOCKED_VAL))
> + if (try_cmpxchg_release(&lock->locked, &locked, 0);
> return; ^------------ ???
This doesn't appear to be a particularly well-tested patch. ;-)
Thanks,
Ingo
Powered by blists - more mailing lists