linux-kernel - Re: [PATCH] slub: Clear __GFP_COMP flag when allocating 0 order page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZhlCogEsWEjTbl8_@casper.infradead.org>
Date: Fri, 12 Apr 2024 15:18:10 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Haifeng Xu <haifeng.xu@...pee.com>
Cc: Vlastimil Babka <vbabka@...e.cz>,
	"Christoph Lameter (Ampere)" <cl@...ux.com>, penberg@...nel.org,
	rientjes@...gle.com, iamjoonsoo.kim@....com,
	akpm@...ux-foundation.org, roman.gushchin@...ux.dev,
	42.hyeyoo@...il.com, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] slub: Clear __GFP_COMP flag when allocating 0 order page

On Fri, Apr 12, 2024 at 10:14:39PM +0800, Haifeng Xu wrote:
> diff --git a/mm/slub.c b/mm/slub.c
> index e7bf1a1a31a8..49a3ebefab86 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -4461,9 +4461,7 @@ static int calculate_sizes(struct kmem_cache *s)
>         if ((int)order < 0)
>                 return 0;
> 
> -       s->allocflags = 0;
> -       if (order)
> -               s->allocflags |= __GFP_COMP;
> +       s->allocflags = __GFP_COMP;
> 
>         if (s->flags & SLAB_CACHE_DMA)
>                 s->allocflags |= GFP_DMA;

Resend this with a proper changelog and you can add:

Reviewed-by: Matthew Wilcox (Oracle) <willy@...radead.org>