linux-kernel - Re: [PATCH] vfio: change the description of VFIO_IOMMU_SPAPR_REGISTER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 12 Apr 2024 08:20:51 -0600
From: Alex Williamson <alex.williamson@...hat.com>
To: JianChunfu <chunfu.jian@...ngroup.cn>
Cc: cohuck@...hat.com, linux-kernel@...r.kernel.org, "kvm@...r.kernel.org"
 <kvm@...r.kernel.org>, Alexey Kardashevskiy <aik@...abs.ru>
Subject: Re: [PATCH] vfio: change the description of
 VFIO_IOMMU_SPAPR_REGISTER_MEMORY

On Fri, 12 Apr 2024 16:53:33 +0800
JianChunfu <chunfu.jian@...ngroup.cn> wrote:

> The type1 ioctl(VFIO_IOMMU_MAP_DMA/VFIO_IOMMU_UNMAP_DMA) won't be called
> in SPAPR machine, which is replaced by VFIO_IOMMU_SPAPR_TCE_CREATE/
> VFIO_IOMMU_SPAPR_TCE_REMOVE, so change the description.

This does not match my understanding of SPAPR which is that memory is
registered for use by MAP_DMA/UNMAP_DMA calls, _CREATE and _REMOVE are
used for managing DMA window apertures.  Thanks,

Alex


> Signed-off-by: JianChunfu <chunfu.jian@...ngroup.cn>
> ---
>  include/uapi/linux/vfio.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
> index 2b68e6cdf..30efc8af4 100644
> --- a/include/uapi/linux/vfio.h
> +++ b/include/uapi/linux/vfio.h
> @@ -1764,7 +1764,7 @@ struct vfio_eeh_pe_op {
>   *
>   * Registers user space memory where DMA is allowed. It pins
>   * user pages and does the locked memory accounting so
> - * subsequent VFIO_IOMMU_MAP_DMA/VFIO_IOMMU_UNMAP_DMA calls
> + * subsequent VFIO_IOMMU_SPAPR_TCE_CREATE/VFIO_IOMMU_SPAPR_TCE_REMOVE calls
>   * get faster.
>   */
>  struct vfio_iommu_spapr_register_memory {