[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZhilSv5xh0hJ2vdX@lizhi-Precision-Tower-5810>
Date: Thu, 11 Apr 2024 23:06:50 -0400
From: Frank Li <Frank.li@....com>
To: Joy Zou <joy.zou@....com>
Cc: peng.fan@....com, vkoul@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, imx@...ts.linux.dev, dmaengine@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v3 2/2] dma: dt-bindings: fsl-edma: clean up unused
"fsl,imx8qm-adma" compatible string
On Fri, Apr 12, 2024 at 11:04:36AM +0800, Joy Zou wrote:
> The eDMA hardware issue only exist imx8QM A0. A0 never mass production.
> The compatible string "fsl,imx8qm-adma" is unused. So remove the
> workaround safely.
You missed change subject:
dt-bindings: fsl-edma: clean up unused "fsl,imx8qm-adma" compatible string
dt-bindings should be first patch, then driver code.
I suggest use the same words, "clean up" or "Remove". keep consistent for
both patches
Frank
>
> Signed-off-by: Joy Zou <joy.zou@....com>
> ---
> Changes for v3:
> 1. modify the commit message.
> 2. remove the unused compatible string "fsl,imx8qm-adma" from allOf property.
> ---
> Documentation/devicetree/bindings/dma/fsl,edma.yaml | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> index 825f4715499e..cf97ea86a7a2 100644
> --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml
> @@ -21,7 +21,6 @@ properties:
> - enum:
> - fsl,vf610-edma
> - fsl,imx7ulp-edma
> - - fsl,imx8qm-adma
> - fsl,imx8qm-edma
> - fsl,imx8ulp-edma
> - fsl,imx93-edma3
> @@ -92,7 +91,6 @@ allOf:
> compatible:
> contains:
> enum:
> - - fsl,imx8qm-adma
> - fsl,imx8qm-edma
> - fsl,imx93-edma3
> - fsl,imx93-edma4
> --
> 2.37.1
>
Powered by blists - more mailing lists