linux-kernel - Re: [PATCH v1] pwm: dwc: allow suspend/resume for 16 channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zhk-7Tp4HzF41Is5@black.fi.intel.com>
Date: Fri, 12 Apr 2024 18:38:24 +0300
From: Raag Jadav <raag.jadav@...el.com>
To: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
Cc: jarkko.nikula@...ux.intel.com, mika.westerberg@...ux.intel.com,
	andriy.shevchenko@...ux.intel.com, linux-pwm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] pwm: dwc: allow suspend/resume for 16 channels

On Fri, Apr 12, 2024 at 01:12:48PM +0200, Uwe Kleine-König wrote:
> Hello,
> 
> On Fri, Apr 12, 2024 at 11:38:12AM +0530, Raag Jadav wrote:
> > diff --git a/drivers/pwm/pwm-dwc.h b/drivers/pwm/pwm-dwc.h
> > index a8b074841ae8..c6e2df5a6122 100644
> > --- a/drivers/pwm/pwm-dwc.h
> > +++ b/drivers/pwm/pwm-dwc.h
> > @@ -38,6 +38,12 @@ struct dwc_pwm_info {
> >  	unsigned int size;
> >  };
> >  
> > +struct dwc_pwm_drvdata {
> > +	const struct dwc_pwm_info *info;
> > +	void __iomem *io_base;
> 
> .io_base is only used during init time and so doesn't need to be tracked
> in driver data.

It will be useful for other features which are WIP.

> Otherwise I (only slightly) dislike
> > +	struct dwc_pwm_drvdata *data;
> because "data" is very generic. I'd call it ddata. But I don't feel
> strong here. I'm happy if you change to "ddata" in v2, I will silently
> apply anyhow if you prefer "data".

I think "data" is more readable, something like "ddata" would make me
re-adjust my glasses ;)

Raag