linux-kernel - Re: [PATCH 1/3] ASoC: dt-bindings: nau8821: Add delay control for ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240412155220.GA2918590-robh@kernel.org>
Date: Fri, 12 Apr 2024 10:52:20 -0500
From: Rob Herring <robh@...nel.org>
To: Seven Lee <wtli@...oton.com>
Cc: broonie@...nel.org, lgirdwood@...il.com, alsa-devel@...a-project.org,
	devicetree@...r.kernel.org, linux-sound@...r.kernel.org,
	krzysztof.kozlowski+dt@...aro.org, linux-kernel@...r.kernel.org,
	conor+dt@...nel.org, perex@...ex.cz, tiwai@...e.com,
	YHCHuang@...oton.com, KCHSU0@...oton.com, CTLIN0@...oton.com,
	SJLIN0@...oton.com, scott6986@...il.com, supercraig0719@...il.com,
	dardar923@...il.com, edson.drosdeck@...il.com,
	u.kleine-koenig@...gutronix.de
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: nau8821: Add delay control for ADC

On Fri, Apr 12, 2024 at 06:35:52PM +0800, Seven Lee wrote:
> Change the original fixed delay to the assignment from the property. It
> will make it more flexible to different platforms to avoid pop noise at
> the beginning of recording.
> 
> Signed-off-by: Seven Lee <wtli@...oton.com>
> ---
>  .../devicetree/bindings/sound/nuvoton,nau8821.yaml        | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> index 054b53954ac3..a726c5a9b067 100644
> --- a/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> +++ b/Documentation/devicetree/bindings/sound/nuvoton,nau8821.yaml
> @@ -103,6 +103,13 @@ properties:
>          just limited to the left adc for design demand.
>      type: boolean
>  
> +  nuvoton,adc-delay-ms:
> +    description: Delay (in ms) to make input path stable and avoid pop noise.
> +        The default value is 125 and range between 125 to 500 ms.

No need to state constraints in prose.

> +    minimum: 125
> +    maximum: 500
> +    default: 125
> +
>    '#sound-dai-cells':
>      const: 0
>  
> @@ -136,6 +143,7 @@ examples:
>              nuvoton,jack-eject-debounce = <0>;
>              nuvoton,dmic-clk-threshold = <3072000>;
>              nuvoton,dmic-slew-rate = <0>;
> +            nuvoton,nuvoton,adc-delay-ms = <125>;
>              #sound-dai-cells = <0>;
>          };
>      };
> -- 
> 2.25.1
>