linux-kernel - Re: [PATCH 2/3] platform/x86/intel/ifs: trace: display batch num in hex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9708f56f-dfe1-4425-abb8-dc7f1bdfd44d@intel.com>
Date: Fri, 12 Apr 2024 11:45:06 -0700
From: "Kuppuswamy, Sathyanarayanan" <sathyanarayanan.kuppuswamy@...el.com>
To: Jithu Joseph <jithu.joseph@...el.com>, <ilpo.jarvinen@...ux.intel.com>,
	<hdegoede@...hat.com>, <markgross@...nel.org>
CC: <linux-kernel@...r.kernel.org>, <platform-driver-x86@...r.kernel.org>,
	<ashok.raj@...el.com>, <tony.luck@...el.com>, <rostedt@...dmis.org>,
	<ravi.v.shankar@...el.com>, <patches@...ts.linux.dev>
Subject: Re: [PATCH 2/3] platform/x86/intel/ifs: trace: display batch num in
 hex


On 4/12/24 10:23 AM, Jithu Joseph wrote:
> In Field Scan test image files are named in ff-mm-ss-<batch02x>.scan
> format. Current trace output, prints the batch number in decimal format.
>
> Make it easier to correlate the trace line to a test image file by
> showing the batch number also in hex format.
>
> Add 0x prefix to all fields in the trace line to make the type explicit.
>
> Signed-off-by: Jithu Joseph <jithu.joseph@...el.com>
> Reviewed-by: Tony Luck <tony.luck@...el.com>
> Reviewed-by: Ashok Raj <ashok.raj@...el.com>
> ---

Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@...ux.intel.com>

>  include/trace/events/intel_ifs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/intel_ifs.h b/include/trace/events/intel_ifs.h
> index 8ce2de120f2d..0d88ebf2c980 100644
> --- a/include/trace/events/intel_ifs.h
> +++ b/include/trace/events/intel_ifs.h
> @@ -28,7 +28,7 @@ TRACE_EVENT(ifs_status,
>  		__entry->status	= status;
>  	),
>  
> -	TP_printk("batch: %.2d, start: %.4x, stop: %.4x, status: %.16llx",
> +	TP_printk("batch: 0x%.2x, start: 0x%.4x, stop: 0x%.4x, status: 0x%.16llx",
>  		__entry->batch,
>  		__entry->start,
>  		__entry->stop,

-- 
Sathyanarayanan Kuppuswamy
Linux Kernel Developer