linux-kernel - Re: [PATCH v2 0/2] Support clean reboot after hibernate on Arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 12 Apr 2024 21:25:01 +0200
From: "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>
To: David Woodhouse <dwmw2@...radead.org>, Will Deacon <will@...nel.org>
CC: Catalin Marinas <catalin.marinas@....com>, Robert Moore
	<robert.moore@...el.com>, Len Brown <lenb@...nel.org>, Sudeep Holla
	<sudeep.holla@....com>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <linux-acpi@...r.kernel.org>,
	<acpica-devel@...ts.linux.dev>, "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH v2 0/2] Support clean reboot after hibernate on Arm64

On 4/12/2024 4:18 PM, David Woodhouse wrote:
> On Fri, 2024-04-12 at 15:05 +0100, Will Deacon wrote:
>> On Mon, Mar 11, 2024 at 12:19:14PM +0000, David Woodhouse wrote:
>>> When the hardware signature in the ACPI FACS changes, the OS is supposed
>>> to perform a clean reboot instead of attempting to resume on a changed
>>> platform.
>>>
>>> Although these patches have a functional dependency, they could be merged
>>> separately. The second patch just won't *see* a FACS table if the ACPICA
>>> fix isn't present.
>>>
>>> v2: Now that the ACPICA patch is merged upstream, note its commit ID
>>>
>>> David Woodhouse (2):
>>>        ACPICA: Detect FACS even for hardware reduced platforms
>>>        arm64: acpi: Honour firmware_signature field of FACS, if it exists
>>>
>>>   arch/arm64/kernel/acpi.c      | 10 ++++++++++
>>>   drivers/acpi/acpica/tbfadt.c  | 30 +++++++++++++-----------------
>>>   drivers/acpi/acpica/tbutils.c |  7 +------
>> Rafael, how would you like the handle this series? The arm64 part has
>> been Acked-by Sudeep, so I'm happy with it.
> Thanks, Will.
>
> Similar question for Rafael on the guest side of the PSCI SYSTEM_OFF2
> series, in particular
> https://lore.kernel.org/kvm/20240319130957.1050637-6-dwmw2@infradead.org/#Z31kernel:power:hibernate.c
> which sets the entering_platform_hibernation flag around the call to
> the standard kernel_power_off() function when invoking it for
> HIBERNATION_SHUTDOWN.

In both cases, please feel free to route the patches as it is convenient 
and add

Acked-by: Rafael J. Wysocki <rafael@...nel.org>

to both of them.