linux-kernel - Re: [PATCH v1 1/1] gpio: pcie-idio-24: Use -ENOTSUPP consistently

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMRc=Mew-w3bChf-Qy5PM00rNNtLziBa7XVP+B7t7xvgSywhAg@mail.gmail.com>
Date: Fri, 12 Apr 2024 21:37:29 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Linus Walleij <linus.walleij@...aro.org>, 
	William Breathitt Gray <william.gray@...aro.org>, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, William Breathitt Gray <wbg@...nel.org>
Subject: Re: [PATCH v1 1/1] gpio: pcie-idio-24: Use -ENOTSUPP consistently

On Wed, Apr 10, 2024 at 8:41 AM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> The GPIO library expects the drivers to return -ENOTSUPP in some cases
> and not using analogue POSIX code. Make the driver to follow this.
>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@...il.com>
> ---
>  drivers/gpio/gpio-pcie-idio-24.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-pcie-idio-24.c b/drivers/gpio/gpio-pcie-idio-24.c
> index 2efd1b1a0805f..7f7f95ad4343d 100644
> --- a/drivers/gpio/gpio-pcie-idio-24.c
> +++ b/drivers/gpio/gpio-pcie-idio-24.c
> @@ -267,7 +267,7 @@ static int idio_24_reg_mask_xlate(struct gpio_regmap *const gpio, const unsigned
>         case IDIO_24_CONTROL_REG:
>                 /* We can only set direction for TTL/CMOS lines */
>                 if (offset < 48)
> -                       return -EOPNOTSUPP;
> +                       return -ENOTSUPP;
>
>                 *reg = IDIO_24_CONTROL_REG;
>                 *mask = CONTROL_REG_OUT_MODE;
> --
> 2.44.0
>

Applied, thanks!

Bart