linux-kernel - Re: [PATCH v3 2/2] arm64: dts: qcom: sa8155p-adp: lower min volt for L13C regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o7ae4a28.fsf@epam.com>
Date: Fri, 12 Apr 2024 20:09:52 +0000
From: Volodymyr Babchuk <Volodymyr_Babchuk@...m.com>
To: Stephan Gerhold <stephan@...hold.net>
CC: "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        Bjorn
 Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski
	<krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] arm64: dts: qcom: sa8155p-adp: lower min volt for
 L13C regulator


Hi Stephan,

Stephan Gerhold <stephan@...hold.net> writes:

> On Fri, Apr 12, 2024 at 07:03:26PM +0000, Volodymyr Babchuk wrote:
>> Voltage regulator L13C is used by SD card IO interface. In order to
>> support UHS modes, IO interface voltage needs to be set to 1.8V. This
>> patch extends minimum voltage range of L13C regulator to allow this.
>> 
>
> I think this one also deserves a Fixes and stable tag. One could argue
> that enabling UHS modes is a new "feature"

Yes, this was my reasoning, actually. I reasoned that the initial commit
("arm64: dts: qcom: sa8155p-adp: Add base dts file") was not obliged to
set voltage ranges correctly as it didn't enabled SDHC2 support. But you
are right,  0deb2624e2d0 ("arm64: dts: qcom: sa8155p-adp: Add support
for uSD card") should have this change.

> but I would say the original
> commit just missed setting the correct voltages with the intended use
> case. I doubt limiting to high speed was intended.
>
> Maybe also add a Suggested-by tag from myself:

Yes, sorry. I should have asked about adding your Suggested-by tag before
posting this change.

> Fixes: 0deb2624e2d0 ("arm64: dts: qcom: sa8155p-adp: Add support for uSD card")
> Cc: stable@...r.kernel.org
> Suggested-by: Stephan Gerhold <stephan@...hold.net>
>
> I believe you do not need to resend just to add these tags, the b4 tool
> should pick them up while applying. It looks like this might not work
> for the Cc: stable tag though...

Well, we can send separate email to stable@...r.kernel.org after this
patch will be applied... I believe it is better than posting v4.


-- 
WBR, Volodymyr