linux-kernel - Re: [PATCH 2/2] wifi: ath11k: support DT ieee80211-freq-limit property to limit channels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 12 Apr 2024 22:21:19 +0200
From: Robert Marko <robimarko@...il.com>
To: Christian Lamparter <christian.lamparter@....uni-stuttgart.de>
Cc: kvalo@...nel.org, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, robh@...nel.org, 
	krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, jjohnson@...nel.org, 
	linux-wireless@...r.kernel.org, netdev@...r.kernel.org, 
	devicetree@...r.kernel.org, ath11k@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] wifi: ath11k: support DT ieee80211-freq-limit
 property to limit channels

On Fri, 12 Apr 2024 at 21:52, Christian Lamparter
<christian.lamparter@....uni-stuttgart.de> wrote:
>
> On 4/12/24 6:24 PM, Robert Marko wrote:
> > The common DT property can be used to limit the available channels
> > but ath11k has to manually call wiphy_read_of_freq_limits().
> >
> > Signed-off-by: Robert Marko <robimarko@...il.com>
>
> I've seen this before.
>
> https://patchwork.kernel.org/project/linux-wireless/patch/ed266944c721de8dbf0fe35f387a3a71b2c84037.1686486468.git.chunkeey@gmail.com/
>
> (dt-binding too. it has/had an ack)
> https://patchwork.kernel.org/project/linux-wireless/patch/fc606d2550d047a53b4289235dd3c0fe23d5daac.1686486468.git.chunkeey@gmail.com/
>
> sooo.... this is awkward.

Definitively,
I completely missed your patch set and we needed this in OpenWrt.

You were, first so your patch set should be applied.

Regards,
Robert



>
> > ---
> >   drivers/net/wireless/ath/ath11k/mac.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
> > index c32be587000d..59bde128d351 100644
> > --- a/drivers/net/wireless/ath/ath11k/mac.c
> > +++ b/drivers/net/wireless/ath/ath11k/mac.c
> > @@ -10124,6 +10124,7 @@ static int __ath11k_mac_register(struct ath11k *ar)
> >       if (ret)
> >               goto err;
> >
> > +     wiphy_read_of_freq_limits(ar->hw->wiphy);
> >       ath11k_mac_setup_ht_vht_cap(ar, cap, &ht_cap);
> >       ath11k_mac_setup_he_cap(ar, cap);
> >
>