linux-kernel - Re: [PATCH net] net: bcmasp: fix memory leak when bringing down if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdb1f2e6-dbe0-4a19-b111-5dd8dbd5d44a@gmail.com>
Date: Fri, 12 Apr 2024 14:09:34 -0700
From: Florian Fainelli <f.fainelli@...il.com>
To: Justin Chen <justin.chen@...adcom.com>, netdev@...r.kernel.org
Cc: Florian Fainelli <florian.fainelli@...adcom.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>,
 "open list:BROADCOM ASP 2.0 ETHERNET DRIVER"
 <bcm-kernel-feedback-list@...adcom.com>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net] net: bcmasp: fix memory leak when bringing down if

On 4/12/24 11:16, Justin Chen wrote:
> When bringing down the TX rings we flush the rings but forget to
> reclaimed the flushed packets. This lead to a memory leak since we
> do not free the dma mapped buffers. This also leads to tx control
> block corruption when bringing down the interface for power
> management.
> 
> Fixes: 490cb412007d ("net: bcmasp: Add support for ASP2.0 Ethernet controller")
> Signed-off-by: Justin Chen <justin.chen@...adcom.com>

Acked-by: Florian Fainelli <florian.fainelli@...adcom.com>
-- 
Florian