linux-kernel - Re: [PATCH] sysrq: Auto release device node using _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024041245-surfboard-expenses-ba74@gregkh>
Date: Fri, 12 Apr 2024 07:20:54 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Roman Storozhenko <romeusmeister@...il.com>
Cc: jirislaby@...nel.org, Julia.Lawall@...ia.fr, skhan@...uxfoundation.org,
	javier.carrasco.cruz@...il.com, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH] sysrq: Auto release device node using __free attribute

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Apr 11, 2024 at 08:28:17PM +0200, Roman Storozhenko wrote:
> This change allows us to put this pointer under automatic scope
> management and get rid of node_put.  Besides, if a new code path is
> introduced we won't need to add a new of_node_put.

We worry about future stuff then, in the future.  So no need for
changing code today for things that are not present at all, otherwise
you would never be finished with anything, right?

Don't make things more complex when it is not needed.  Only add
complexity when it is needed.

thanks,

greg k-h