linux-kernel - Re: [PATCH v2] ACPI: fan: Add hwmon support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e5398618-5140-4553-8dab-6f5ad73de805@roeck-us.net>
Date: Thu, 11 Apr 2024 17:57:25 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Armin Wolf <W_Armin@....de>
Cc: Mikael Lund Jepsen <mlj@...elec.com>,
	"rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>,
	"lenb@...nel.org" <lenb@...nel.org>,
	"jdelvare@...e.com" <jdelvare@...e.com>,
	"linux@...ssschuh.net" <linux@...ssschuh.net>,
	"ilpo.jarvinen@...ux.intel.com" <ilpo.jarvinen@...ux.intel.com>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-hwmon@...r.kernel.org" <linux-hwmon@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"platform-driver-x86@...r.kernel.org" <platform-driver-x86@...r.kernel.org>
Subject: Re: [PATCH v2] ACPI: fan: Add hwmon support

On Fri, Apr 12, 2024 at 01:38:11AM +0200, Armin Wolf wrote:
[ .. ]
> I just noticed that the drvdata argument of the is_visible callback is marked as const, so i cannot use dev_get_drvdata() on the resulting ACPI device.
> Guenter, would it be ok to make drvdata non-const in a separate patch series?
> 

I don't know what you are trying to do (the is_visible callback
isn't supposed to change the information passed to it), but not
really.

Guenter