linux-kernel - Re: [PATCH v2] HID: i2c-hid: wait for i2c touchpad deep-sleep to power-up transition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 12 Apr 2024 14:28:32 +0800
From: Kai-Heng Feng <kai.heng.feng@...onical.com>
To: Łukasz Majczak <lma@...omium.org>
Cc: Johan Hovold <johan@...nel.org>, Jiri Kosina <jikos@...nel.org>, 
	Dmitry Torokhov <dtor@...omium.org>, Benjamin Tissoires <benjamin.tissoires@...hat.com>, 
	Douglas Anderson <dianders@...omium.org>, Hans de Goede <hdegoede@...hat.com>, 
	Maxime Ripard <mripard@...nel.org>, Johan Hovold <johan+linaro@...nel.org>, 
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Radoslaw Biernacki <rad@...omium.org>
Subject: Re: [PATCH v2] HID: i2c-hid: wait for i2c touchpad deep-sleep to
 power-up transition

Hi Łukasz,

On Thu, Apr 11, 2024 at 10:23 PM Łukasz Majczak <lma@...omium.org> wrote:
>
> > Sure, but what about other transactions that are initiated by the host
> > (e.g. SET_POWER)?
> >
> Somehow it is problematic only on reboot and works just fine on
> suspend/resume and
> set_power.
> I will dig more and try to find out what the difference is.

If cold boot doesn't have such issue, maybe I2C_HID_PWR_SLEEP
shouldn't be used by reboot?

Kai-Heng

>
> > Perhaps this hack at probe is enough for your use case, but is an
> > incomplete hack and at a minimum you'd need to add a comment explaining
> > why it is there.
> >
> You mean a comment in the code ?
>
> Lukasz