linux-kernel - Re: [PATCH v7 0/5] Add Tegra Security Engine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZhjjNWKexg8p8cJp@gondor.apana.org.au>
Date: Fri, 12 Apr 2024 15:31:01 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Akhil R <akhilrajeev@...dia.com>
Cc: davem@...emloft.net, robh@...nel.org, krzysztof.kozlowski+dt@...aro.org,
	conor+dt@...nel.org, thierry.reding@...il.com, jonathanh@...dia.com,
	catalin.marinas@....com, will@...nel.org, mperttunen@...dia.com,
	airlied@...il.com, daniel@...ll.ch, linux-crypto@...r.kernel.org,
	devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH v7 0/5] Add Tegra Security Engine driver

On Wed, Apr 03, 2024 at 03:30:34PM +0530, Akhil R wrote:
> Add support for Tegra Security Engine which can accelerates various
> crypto algorithms. The Engine has two separate instances within for
> AES and HASH algorithms respectively.
> 
> The driver registers two crypto engines - one for AES and another for
> HASH algorithms and these operate independently and both uses the host1x
> bus. Additionally, it provides  hardware-assisted key protection for up to
> 15 symmetric keys which it can use for the cipher operations.
> 
> v6->v7:
> * Move fallback_tfm and fallback_req to end of struct
> * Set reqsize and statesize based on fallback_tfm
> * Remove ofb(aes)
> v5->v6:
> * Move copy/pase of intermediate results in export()/import() to
>   'update()' callback for CMAC as well.
> * Check for rctx size when using fallback alg.
> * Updated blocksizes to align with generic implementation
> * Combined GCM and CCM init into aead_cra_init
> * Updates to handle invalid cases better
> * Reduce log levels for invalid cases to dev_dbg
> v4->v5:
> * Move copy/paste of intermediate results in export()/import() to
>   'update()' callback
> v3->v4:
> * Remove unused header in bindings doc.
> * Update commit message in host1x change.
> * Fix test bot warning.
> v2->v3:
> * Update compatible in driver and device trees.
> * Remove extra new lines and symbols in binding doc.
> v1->v2:
> * Update probe errors with 'dev_err_probe'.
> * Clean up function prototypes and redundant prints.
> * Remove readl/writel wrappers.
> * Fix test bot warnings.
> 
> 
> Akhil R (5):
>   dt-bindings: crypto: Add Tegra Security Engine
>   gpu: host1x: Add Tegra SE to SID table
>   crypto: tegra: Add Tegra Security Engine driver
>   arm64: defconfig: Enable Tegra Security Engine
>   arm64: tegra: Add Tegra Security Engine DT nodes
> 
>  .../crypto/nvidia,tegra234-se-aes.yaml        |   52 +
>  .../crypto/nvidia,tegra234-se-hash.yaml       |   52 +
>  MAINTAINERS                                   |    5 +
>  arch/arm64/boot/dts/nvidia/tegra234.dtsi      |   16 +
>  arch/arm64/configs/defconfig                  |    1 +
>  drivers/crypto/Kconfig                        |    8 +
>  drivers/crypto/Makefile                       |    1 +
>  drivers/crypto/tegra/Makefile                 |    9 +
>  drivers/crypto/tegra/tegra-se-aes.c           | 1933 +++++++++++++++++
>  drivers/crypto/tegra/tegra-se-hash.c          | 1060 +++++++++
>  drivers/crypto/tegra/tegra-se-key.c           |  156 ++
>  drivers/crypto/tegra/tegra-se-main.c          |  439 ++++
>  drivers/crypto/tegra/tegra-se.h               |  560 +++++
>  drivers/gpu/host1x/dev.c                      |   24 +
>  14 files changed, 4316 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/crypto/nvidia,tegra234-se-aes.yaml
>  create mode 100644 Documentation/devicetree/bindings/crypto/nvidia,tegra234-se-hash.yaml
>  create mode 100644 drivers/crypto/tegra/Makefile
>  create mode 100644 drivers/crypto/tegra/tegra-se-aes.c
>  create mode 100644 drivers/crypto/tegra/tegra-se-hash.c
>  create mode 100644 drivers/crypto/tegra/tegra-se-key.c
>  create mode 100644 drivers/crypto/tegra/tegra-se-main.c
>  create mode 100644 drivers/crypto/tegra/tegra-se.h
> 
> -- 
> 2.43.2

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt