linux-kernel - Re: [PATCH mfd v1 2/2] mfd: rsmu: add FemtoClock3 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240412074258.GP2399047@google.com>
Date: Fri, 12 Apr 2024 08:42:58 +0100
From: Lee Jones <lee@...nel.org>
To: Min Li <lnimi@...mail.com>
Cc: linux-kernel@...r.kernel.org, Min Li <min.li.xe@...esas.com>
Subject: Re: [PATCH mfd v1 2/2] mfd: rsmu: add FemtoClock3 support

Did you submit this set as --thread?

The 2 patches are completely separate in my inbox.

On Thu, 11 Apr 2024, Min Li wrote:

> From: Min Li <min.li.xe@...esas.com>
> 
> The RENESAS FemtoClock3 Wireless is a high-performance
> jitter attenuator, frequency translator, and clock
> synthesizer. This patch only adds support for I2C.

54 chars is too short, should be more like 70+.

What I2C support is being added here?

> Signed-off-by: Min Li <min.li.xe@...esas.com>
> ---
>  drivers/mfd/rsmu_core.c  | 10 +++++-----
>  drivers/mfd/rsmu_i2c.c   | 16 ++++++++--------
>  include/linux/mfd/rsmu.h |  4 ++--
>  3 files changed, 15 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/mfd/rsmu_core.c b/drivers/mfd/rsmu_core.c
> index 29437fd0b..951ddd92c 100644
> --- a/drivers/mfd/rsmu_core.c
> +++ b/drivers/mfd/rsmu_core.c
> @@ -40,12 +40,12 @@ static struct mfd_cell rsmu_sabre_devs[] = {
>  	},
>  };
>  
> -static struct mfd_cell rsmu_sl_devs[] = {
> +static struct mfd_cell rsmu_fc3_devs[] = {
>  	[RSMU_PHC] = {
> -		.name = "8v19n85x-phc",
> +		.name = "rc38xxx-phc",

You don't say anything about why 8v19n85x-phc is being removed in the
commit message.  Please describe the whole change properly.

>  	},
>  	[RSMU_CDEV] = {
> -		.name = "8v19n85x-cdev",
> +		.name = "rc38xxx-cdev",
>  	},
>  };
>  
> @@ -61,8 +61,8 @@ int rsmu_core_init(struct rsmu_ddata *rsmu)
>  	case RSMU_SABRE:
>  		cells = rsmu_sabre_devs;
>  		break;
> -	case RSMU_SL:
> -		cells = rsmu_sl_devs;
> +	case RSMU_FC3:
> +		cells = rsmu_fc3_devs;
>  		break;
>  	default:
>  		dev_err(rsmu->dev, "Unsupported RSMU device type: %d\n", rsmu->type);
> diff --git a/drivers/mfd/rsmu_i2c.c b/drivers/mfd/rsmu_i2c.c
> index cba64f107..a3f50a184 100644
> --- a/drivers/mfd/rsmu_i2c.c
> +++ b/drivers/mfd/rsmu_i2c.c
> @@ -262,11 +262,11 @@ static const struct regmap_config rsmu_sabre_regmap_config = {
>  	.can_multi_write = true,
>  };
>  
> -static const struct regmap_config rsmu_sl_regmap_config = {
> +static const struct regmap_config rsmu_fc3_regmap_config = {
>  	.reg_bits = 16,
>  	.val_bits = 8,
>  	.reg_format_endian = REGMAP_ENDIAN_BIG,
> -	.max_register = 0x340,
> +	.max_register = 0xE88,
>  	.cache_type = REGCACHE_NONE,
>  	.can_multi_write = true,
>  };
> @@ -302,8 +302,8 @@ static int rsmu_i2c_probe(struct i2c_client *client)
>  	case RSMU_SABRE:
>  		cfg = &rsmu_sabre_regmap_config;
>  		break;
> -	case RSMU_SL:
> -		cfg = &rsmu_sl_regmap_config;
> +	case RSMU_FC3:
> +		cfg = &rsmu_fc3_regmap_config;
>  		break;
>  	default:
>  		dev_err(rsmu->dev, "Unsupported RSMU device type: %d\n", rsmu->type);
> @@ -336,8 +336,8 @@ static const struct i2c_device_id rsmu_i2c_id[] = {
>  	{ "8a34001",  RSMU_CM },
>  	{ "82p33810", RSMU_SABRE },
>  	{ "82p33811", RSMU_SABRE },
> -	{ "8v19n850", RSMU_SL },
> -	{ "8v19n851", RSMU_SL },
> +	{ "rc38xxx0", RSMU_FC3 },
> +	{ "rc38xxx1", RSMU_FC3 },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(i2c, rsmu_i2c_id);
> @@ -347,8 +347,8 @@ static const struct of_device_id rsmu_i2c_of_match[] = {
>  	{ .compatible = "idt,8a34001",  .data = (void *)RSMU_CM },
>  	{ .compatible = "idt,82p33810", .data = (void *)RSMU_SABRE },
>  	{ .compatible = "idt,82p33811", .data = (void *)RSMU_SABRE },
> -	{ .compatible = "idt,8v19n850", .data = (void *)RSMU_SL },
> -	{ .compatible = "idt,8v19n851", .data = (void *)RSMU_SL },
> +	{ .compatible = "idt,rc38xxx0", .data = (void *)RSMU_FC3 },
> +	{ .compatible = "idt,rc38xxx1", .data = (void *)RSMU_FC3 },
>  	{}
>  };
>  MODULE_DEVICE_TABLE(of, rsmu_i2c_of_match);
> diff --git a/include/linux/mfd/rsmu.h b/include/linux/mfd/rsmu.h
> index 0379aa207..b4a90fc81 100644
> --- a/include/linux/mfd/rsmu.h
> +++ b/include/linux/mfd/rsmu.h
> @@ -11,11 +11,11 @@
>  #define RSMU_MAX_WRITE_COUNT	(255)
>  #define RSMU_MAX_READ_COUNT	(255)
>  
> -/* The supported devices are ClockMatrix, Sabre and SnowLotus */
> +/* The supported devices are ClockMatrix, Sabre and FemtoClock3 */
>  enum rsmu_type {
>  	RSMU_CM		= 0x34000,
>  	RSMU_SABRE	= 0x33810,
> -	RSMU_SL		= 0x19850,
> +	RSMU_FC3	= 0x38312,
>  };
>  
>  /**
> -- 
> 2.39.2
> 

-- 
Lee Jones [李琼斯]