linux-kernel - Re: [PATCH] rust: remove unneeded `kernel::prelude` imports from doctests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <02b9d259-03d4-4245-8b35-ec4d11b9c323@proton.me>
Date: Fri, 12 Apr 2024 08:48:53 +0000
From: Benno Lossin <benno.lossin@...ton.me>
To: Nell Shamrell-Harrington <nells@...ux.microsoft.com>, ojeda@...nel.org, alex.gaynor@...il.com, wedsonaf@...il.com
Cc: boqun.feng@...il.com, gary@...yguo.net, bjorn3_gh@...tonmail.com, a.hindborg@...sung.com, aliceryhl@...gle.com, fujita.tomonori@...il.com, tmgross@...ch.edu, yakoyoku@...il.com, kent.overstreet@...il.com, matthew.brost@...el.com, kernel@...entinobst.de, netdev@...r.kernel.org, rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: remove unneeded `kernel::prelude` imports from doctests

On 12.04.24 00:53, Nell Shamrell-Harrington wrote:
> Rust doctests implicitly include `kernel::prelude::*`.
> 
> Removes explicit `kernel::prelude` imports from doctests.
> 
> Suggested-by: Miguel Ojeda <ojeda@...nel.org>
> Link: https://github.com/Rust-for-Linux/linux/issues/1064
> Signed-off-by: Nell Shamrell-Harrington <nells@...ux.microsoft.com>
> ---
>  rust/kernel/init.rs      | 6 +++---
>  rust/kernel/net/phy.rs   | 1 -
>  rust/kernel/workqueue.rs | 3 ---
>  3 files changed, 3 insertions(+), 7 deletions(-)

Reviewed-by: Benno Lossin <benno.lossin@...ton.me>

-- 
Cheers,
Benno