linux-kernel - Re: [PATCH v2 0/2] ACPICA: AEST: Support AEST V2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zhj-VtiWyTd-zq5w@bogus>
Date: Fri, 12 Apr 2024 10:26:46 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: Ruidong Tian <tianruidong@...ux.alibaba.com>
Cc: robert.moore@...el.com, rafael.j.wysocki@...el.com, lenb@...nel.org,
	linux-acpi@...r.kernel.org, acpica-devel@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] ACPICA: AEST: Support AEST V2

On Fri, Apr 12, 2024 at 10:41:31AM +0800, Ruidong Tian wrote:
>
>
> 在 2024/4/11 17:14, Sudeep Holla 写道:
> > On Thu, Apr 11, 2024 at 03:54:48PM +0800, Ruidong Tian wrote:
> > >
> > >
> > > 在 2024/4/10 17:22, Sudeep Holla 写道:
> > > > On Wed, Apr 10, 2024 at 02:36:00PM +0800, Ruidong Tian wrote:
> > > > > AEST V2 was published[1], add V2 support based on AEST V1.
> > > > >
> > > >
> > > > Any changes to ACPICA has to get merged in the external ACPICA project.
> > > > Refer [1] for details from Rafael. You can also refer [2] in the kernel
> > > > docs.
> > > >
> > >
> > > Patch1 is just a fix to follow kernel code style.
> >
> > IIUC such changes are not allowed as ACPICA changes are always imported
> > from the external project. So you have to take same route as patch2
>
> In ACPICA, all struct use typedef which is not allowed in kernel:
>
>     It's a **mistake** to use typedef for structures and pointers[1].
>

Fair enough.

> I see all other structs in actbl2.h follow this rule, so I fix all typedef
> in AEST struct to follow kernel code style. But i can not apple this fix in
> ACPICA. Patch1 is just a kernel patch.
>

No patches from the kernel tree applies to APCICA because of some variations
in the coding style that the import script modifies when applying to the
kernel. So make similar changes in APCICA project and send it there. It will
get imported if it gets merged there.

--
Regards,
Sudeep