linux-kernel - RE: [PATCH v2 12/13] iommu/vt-d: Add an irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BN9PR11MB5276051CAD86374C666ACFD48C042@BN9PR11MB5276.namprd11.prod.outlook.com>
Date: Fri, 12 Apr 2024 09:36:10 +0000
From: "Tian, Kevin" <kevin.tian@...el.com>
To: Jacob Pan <jacob.jun.pan@...ux.intel.com>, LKML
	<linux-kernel@...r.kernel.org>, X86 Kernel <x86@...nel.org>, Peter Zijlstra
	<peterz@...radead.org>, "iommu@...ts.linux.dev" <iommu@...ts.linux.dev>,
	Thomas Gleixner <tglx@...utronix.de>, Lu Baolu <baolu.lu@...ux.intel.com>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>, "Hansen, Dave"
	<dave.hansen@...el.com>, Joerg Roedel <joro@...tes.org>, "H. Peter Anvin"
	<hpa@...or.com>, Borislav Petkov <bp@...en8.de>, Ingo Molnar
	<mingo@...hat.com>
CC: "Luse, Paul E" <paul.e.luse@...el.com>, "Williams, Dan J"
	<dan.j.williams@...el.com>, Jens Axboe <axboe@...nel.dk>, "Raj, Ashok"
	<ashok.raj@...el.com>, "maz@...nel.org" <maz@...nel.org>, "seanjc@...gle.com"
	<seanjc@...gle.com>, Robin Murphy <robin.murphy@....com>,
	"jim.harris@...sung.com" <jim.harris@...sung.com>, "a.manzanares@...sung.com"
	<a.manzanares@...sung.com>, Bjorn Helgaas <helgaas@...nel.org>, "Zeng, Guang"
	<guang.zeng@...el.com>, "robert.hoo.linux@...il.com"
	<robert.hoo.linux@...il.com>
Subject: RE: [PATCH v2 12/13] iommu/vt-d: Add an irq_chip for posted MSIs

> From: Jacob Pan <jacob.jun.pan@...ux.intel.com>
> Sent: Saturday, April 6, 2024 6:31 AM
> 
> + *
> + * For the example below, 3 MSIs are coalesced into one CPU notification.
> Only
> + * one apic_eoi() is needed.
> + *
> + * __sysvec_posted_msi_notification()
> + *	irq_enter();
> + *		handle_edge_irq()
> + *			irq_chip_ack_parent()
> + *				dummy(); // No EOI
> + *			handle_irq_event()
> + *				driver_handler()
> + *	irq_enter();
> + *		handle_edge_irq()
> + *			irq_chip_ack_parent()
> + *				dummy(); // No EOI
> + *			handle_irq_event()
> + *				driver_handler()
> + *	irq_enter();
> + *		handle_edge_irq()
> + *			irq_chip_ack_parent()
> + *				dummy(); // No EOI
> + *			handle_irq_event()
> + *				driver_handler()

typo: you added three irq_enter()'s here

> + *	apic_eoi()
> + * irq_exit()
> + */
> +static struct irq_chip intel_ir_chip_post_msi = {
> +	.name			= "INTEL-IR-POST",
> +	.irq_ack		= dummy,
> +	.irq_set_affinity	= intel_ir_set_affinity,
> +	.irq_compose_msi_msg	= intel_ir_compose_msi_msg,
> +	.irq_set_vcpu_affinity	= intel_ir_set_vcpu_affinity,
> +};

What about putting this patch at end of the series (combining the
change in intel_irq_remapping_alloc()) to finally enable this
feature?

It reads slightly better to me to first get those callbacks extended
to deal with the new mechanism (i.e. most changes in patch13)
before using them in the new irqchip. 😊