linux-kernel - Re: [PATCH 4/5] Kconfig: Enable APM X-Gene RTC for XuanTie TH1520

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 12 Apr 2024 10:47:36 +0100
From: Conor Dooley <conor.dooley@...rochip.com>
To: <wefu@...hat.com>
CC: <jszhang@...nel.org>, <alexandre.belloni@...tlin.com>, <robh@...nel.org>,
	<krzysztof.kozlowski+dt@...aro.org>, <conor+dt@...nel.org>,
	<guoren@...nel.org>, <paul.walmsley@...ive.com>, <palmer@...belt.com>,
	<aou@...s.berkeley.edu>, <linux-riscv@...ts.infradead.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-rtc@...r.kernel.org>
Subject: Re: [PATCH 4/5] Kconfig: Enable APM X-Gene RTC for XuanTie TH1520

On Fri, Apr 12, 2024 at 04:01:46PM +0800, wefu@...hat.com wrote:
> From: Wei Fu <wefu@...hat.com>
> 
> This patch enables APM X-Gene RTC for XuanTie TH1520.
> 
> Signed-off-by: Wei Fu <wefu@...hat.com>
> ---
>  drivers/rtc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
> index 3a89f1e6095d..b219aeef4ce9 100644
> --- a/drivers/rtc/Kconfig
> +++ b/drivers/rtc/Kconfig
> @@ -1880,7 +1880,7 @@ config RTC_DRV_MT7622
>  config RTC_DRV_XGENE
>  	tristate "APM X-Gene RTC"
>  	depends on HAS_IOMEM
> -	depends on ARCH_XGENE || COMPILE_TEST
> +	depends on ARCH_XGENE || ARCH_THEAD || COMPILE_TEST
>  	help
>  	  If you say yes here you get support for the APM X-Gene SoC real time
>  	  clock.

If I was configuring my system by reading menuconfig, I would have
absolutely no idea that this driver supports platforms other than the
X-Gene one. I think the Kconfig stuff for this likely needs an update to
convey that it's no longer just one SoC family that's supported here.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)