linux-kernel - Re: [PATCH] rust: helpers: Fix grammar in comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 12 Apr 2024 13:05:27 +0200
From: Alice Ryhl <aliceryhl@...gle.com>
To: Thorsten Blum <thorsten.blum@...lux.com>
Cc: Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Wedson Almeida Filho <wedsonaf@...il.com>, Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...sung.com>, 
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: helpers: Fix grammar in comment

On Thu, Apr 11, 2024 at 10:55 PM Thorsten Blum <thorsten.blum@...lux.com> wrote:
>
> s/directly the bindings/the bindings directly/
>
> Signed-off-by: Thorsten Blum <thorsten.blum@...lux.com>
> ---
>  rust/helpers.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/rust/helpers.c b/rust/helpers.c
> index 70e59efd92bc..4c8b7b92a4f4 100644
> --- a/rust/helpers.c
> +++ b/rust/helpers.c
> @@ -4,7 +4,7 @@
>   * cannot be called either. This file explicitly creates functions ("helpers")
>   * that wrap those so that they can be called from Rust.
>   *
> - * Even though Rust kernel modules should never use directly the bindings, some
> + * Even though Rust kernel modules should never use the bindings directly, some
>   * of these helpers need to be exported because Rust generics and inlined
>   * functions may not get their code generated in the crate where they are
>   * defined. Other helpers, called from non-inline functions, may not be

Reviewed-by: Alice Ryhl <aliceryhl@...gle.com>