linux-kernel - Re: [PATCH v9 5/9] clk: mmp: Add Marvell PXA1908 clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <58b23157c088cb4774d579cc8700de85.sboyd@kernel.org>
Date: Thu, 11 Apr 2024 19:57:09 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Catalin Marinas <catalin.marinas@....com>, Conor Dooley <conor+dt@...nel.org>, Duje Mihanović <duje.mihanovic@...le.hr>, Guilherme G. Piccoli <gpiccoli@...lia.com>, Haojian Zhuang <haojian.zhuang@...aro.org>, Kees Cook <keescook@...omium.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Linus Walleij <linus.walleij@...aro.org>, Lubomir Rintel <lkundrak@...sk>, Michael Turquette <mturquette@...libre.com>, Rob Herring <robh+dt@...nel.org>, Rob Herring <robh@...nel.org>, Tony Lindgren <tony@...mide.com>, Tony Luck <tony.luck@...el.com>, Will Deacon <will@...nel.org>
Cc: phone-devel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht, Karel Balej <balejk@...fyz.cz>, David Wronek <david@...nlining.org>, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v9 5/9] clk: mmp: Add Marvell PXA1908 clock driver

Quoting Duje Mihanović (2024-04-11 03:15:34)
> On 4/11/2024 10:00 AM, Stephen Boyd wrote:
> > 
> > Is there a reason this file can't be a platform driver?
> 
> Not that I know of, I did it like this only because the other in-tree 
> MMP clk drivers do so. I guess the initialization should look like any 
> of the qcom GCC drivers then?

Yes.

> 
> While at it, do you think the other MMP clk drivers could use a conversion?
> 

Sure, go for it. I'm a little wary if the conversion cannot be tested
though. It doesn't hurt that other drivers haven't been converted.