[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Zhn8bjex94DpkGBw@yilunxu-OptiPlex-7050>
Date: Sat, 13 Apr 2024 11:30:54 +0800
From: Xu Yilun <yilun.xu@...ux.intel.com>
To: Peter Colberg <peter.colberg@...el.com>
Cc: Wu Hao <hao.wu@...el.com>, Tom Rix <trix@...hat.com>,
Moritz Fischer <mdf@...nel.org>, Xu Yilun <yilun.xu@...el.com>,
linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org,
Russ Weight <russ.weight@...ux.dev>,
Marco Pagani <marpagan@...hat.com>,
Matthew Gerlach <matthew.gerlach@...ux.intel.com>
Subject: Re: [PATCH v2] fpga: dfl: remove unused member pdata from struct
dfl_{afu,fme}
On Sat, Apr 13, 2024 at 11:10:22AM +0800, Xu Yilun wrote:
> On Mon, Apr 01, 2024 at 02:49:15PM -0400, Peter Colberg wrote:
> > The member pdata was added to struct dfl_afu in commit 857a26222ff7 ("fpga:
> > dfl: afu: add afu sub feature support") and to struct dfl_fme in commit
Sorry, I didn't apply. Please don't wrap the git commit description. Put
them in a new line but no wrap, if you have to reference git commit in
changelog.
> > 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature
> > support").
This sentence is actually not useful, I suggest you just remove it and
add a Fix: tag below. That makes reviewers quickly find what the
problem. Also avoid the git commit references fragments the changelog
too much.
Thanks,
Yilun
> > It is set in function {afu,fme}_dev_init() but never used.
> >
> > Signed-off-by: Peter Colberg <peter.colberg@...el.com>
> > Reviewed-by: Matthew Gerlach <matthew.gerlach@...ux.intel.com>
>
> Acked-by: Xu Yilun <yilun.xu@...el.com>
>
> Applied to for-next.
>
Powered by blists - more mailing lists